Add vue-router helper classes and example #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBerger98
changed the title
jourdain
reviewed
Jan 28, 2022
trame/html/router/__init__.py
Outdated
| class RouterView(AbstractElement): | ||
| def __init__(self, children=None, **kwargs): | ||
| super().__init__("router-view", children=children, **kwargs) | ||
| self._attr_names += [] |
There was a problem hiding this comment.
can remove that line self._attr_names += []
jourdain
reviewed
Jan 28, 2022
trame/layouts/core.py
Outdated
| "name": name, | ||
| "path": path, | ||
| "component": { | ||
| "template": template.html, |
There was a problem hiding this comment.
You may want to defer the template.html evaluation to later.
There was a problem hiding this comment.
Maybe you just pass the template to template and you do a pass somewhere in layout.start to eval to html any isinstance(template, AbstractElement).
|
BTW, I love the idea! |
DavidBerger98
force-pushed
the
add-router-example
branch
from
46d57ab
to
f3f6c60
Compare
DavidBerger98
force-pushed
the
add-router-example
branch
from
f3f6c60
to
7f4b776
Compare
jourdain
reviewed
Jan 31, 2022
|
I guess, you just need to resolve the conflict. Otherwise it looks good. |
|
Thank you for the review, @jourdain :) |
|
Thanks for your contribution! |
|
🎉 This PR is included in version 1.14.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
BTW, don't forget to merge the PR for py-web-vue as well, since this PR depends on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple demo to use the Vue-Router in Trame to create multi-page applications.
I suggest two ways to add a new route.
layout.add_routeandlayout.with_route. See the example.Any more/other suggestions?
(Depends on this PR in py-web-vue: Kitware/py-web-vue#11)