SVGLandmarkRepresentation are shared amongst every instance

[agirault]

When using LineWidget, all the text svg representations use the same position.

https://github.com/Kitware/vtk-js/blob/master/Sources/Widgets/SVG/SVGLandmarkRepresentation/index.js#L84

Might occur on other SVG representations.

[jourdain]

Indeed that is the issue

[jourdain]

Objects share their references... You need a function to create object or put them into the model at the execution of vtkSVGLandmarkRepresentation() function.

[finetjul]

Objects share their references... You need a function to create object or put them into the model at the execution of vtkSVGLandmarkRepresentation() function.

It seems that it is a recurring error. How about changing DEFAULT_VALUES into a function ? e.g.

const defaultValues = () => {...};
...
Object.assign(model, defaultValues(), initialValues);

[jourdain]

I wanted to do that but I was worried to do the refactor work everywhere. But this could be done on case by case...

[jourdain]

at that point you can also just define it as (no need to create a lambda)

function defaultValues(initialValues) {
   return {
       a, b, c, 
       ...initialValues,
   };
}

[github-actions]

🎉 This issue has been resolved in version 16.10.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀