Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic triggered by conflicting CLI switches #11

Closed
ryzhyk opened this issue Jul 7, 2021 · 2 comments
Closed

Panic triggered by conflicting CLI switches #11

ryzhyk opened this issue Jul 7, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ryzhyk
Copy link

ryzhyk commented Jul 7, 2021

It appears that --differential and --replay-logs flags are mutually exclusive, but instead of returning an error message to that effect ddshow panics. Also it is not clear from the documentation that --differential (and other flags) are only meaningful in the network mode.

lryzhyk@nerpa:~/projects/differential-datalog/java/test$ ddshow --differential --replay-logs timely_trace/
[0s] Loading Timely replay from timely_trace/: loaded 2 replay files
thread 'main' panicked at 'the differential listener should be created when `args.differential_enabled` is true', src/replay_loading.rs:151:59
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
@Kixiron
Copy link
Owner

Kixiron commented Jul 7, 2021

This was a bug, I believe I fixed it with some local stuff that I hadn't pushed yet, can you try latest master?

@Kixiron Kixiron self-assigned this Jul 7, 2021
@Kixiron Kixiron added the bug Something isn't working label Jul 7, 2021
@ryzhyk
Copy link
Author

ryzhyk commented Jul 7, 2021

Yep, that solved it. --differential now has the effect of enabling the replay of the differential trace if it happens to exist in the same directory.

@ryzhyk ryzhyk closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants