Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a custom protocol for ddshow #4

Open
Kixiron opened this issue Jun 17, 2021 · 0 comments
Open

Create a custom protocol for ddshow #4

Kixiron opened this issue Jun 17, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@Kixiron
Copy link
Owner

Kixiron commented Jun 17, 2021

In an effort to stay backwards compatible with timely's builtin logging streams, DDShow currently uses separate tcp streams for timely, differential and progress logging. However, with the introduction of ddshow-sink and the rkyv types we have the basis to make an entirely custom protocol that's significantly easier to use

Pros:

  • Doesn't require up to three separate tcp streams to be specified by users
  • Doesn't require the user to know the number of timely workers in the target program
  • Could allow intermittent logging (currently the builtin timely loggers panic and crash the target program if either side disconnects)

Cons:

  • Increases complexity some more
  • Loses backcompat with timely stuff (only to an extent though, the current abomonated sink/streams could still be kept and be comparable with timely's stock stuff)

cc @ryzhyk

@Kixiron Kixiron added the enhancement New feature or request label Jun 17, 2021
@Kixiron Kixiron self-assigned this Jun 17, 2021
@Kixiron Kixiron added this to To do in Roadmap via automation Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Roadmap
To do
Development

No branches or pull requests

1 participant