Removed unused features #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After better analysis it was determined that these features don't help with forward compatibility and only slightly improve convenience. The noise is probably not worth it. `bitcoin_*` were somewhat more interesting because the `bitcoin` crate has sad `no_std` support but there's hope it'll be improved and even if not adding features is better than removing. (The features weren't released yet.) Closes #10
Kixunil
force-pushed
the
remove-unused-features
branch
from
aa3b36c
to
0df26b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After better analysis it was determined that these features don't help
with forward compatibility and only slightly improve convenience. The
noise is probably not worth it.
bitcoin_*were somewhat more interesting because thebitcoincratehas sad
no_stdsupport but there's hope it'll be improved and even ifnot adding features is better than removing. (The features weren't
released yet.)
Closes #10