Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[form] Reduce and enforce DEFAULT_MIN_FILL_AMOUNT #2317

Open
Atmosfearful opened this issue Feb 21, 2024 · 0 comments
Open

[form] Reduce and enforce DEFAULT_MIN_FILL_AMOUNT #2317

Atmosfearful opened this issue Feb 21, 2024 · 0 comments
Assignees
Labels
carbonmark enhancement New feature or request

Comments

@Atmosfearful
Copy link
Collaborator

Atmosfearful commented Feb 21, 2024

Describe the bug
Change it from 1 to 0.001
Make sure ICR doesn't break (icr can't go below 1)
Make sure we are only using this value to set the min fill during listing creation, in other parts of the application we need to read the value provided for the actual listing (because old listings will still be 1, and future listings might someday be even more than that)
Use the minFillAmount value to validate the form here and prevent the user from trying to retire a value < the listing's min fill
https://www.carbonmark.com/projects/VCS-1764-2020/retire/0x734db5a54215c163b1372fb1cc860f40d6a90ccea89731433b9ca48cdc358039

@Atmosfearful Atmosfearful added the enhancement New feature or request label Feb 21, 2024
@Atmosfearful Atmosfearful changed the title Reduce and enforce DEFAULT_MIN_FILL_AMOUNT and Reduce and enforce DEFAULT_MIN_FILL_AMOUNT Feb 21, 2024
@jabby09 jabby09 changed the title Reduce and enforce DEFAULT_MIN_FILL_AMOUNT [form] Reduce and enforce DEFAULT_MIN_FILL_AMOUNT Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carbonmark enhancement New feature or request
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants