tests/test_dom_tag.py:20: AssertionError while building for i686

[benalb]

Trying to build void-linux package for i686, fails in test_dom_tag.py:

 =================================== FAILURES ================================
__________________________ test___get_thread_context ___________________________

 monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0xf63bec30>

def test___get_thread_context(monkeypatch):
    greenlet = mock.Mock()
    greenlet.getcurrent.return_value = 100
    monkeypatch.setattr(sut, 'greenlet', greenlet)

    threading = mock.Mock()
    threading.current_thread.return_value = 200
    monkeypatch.setattr(sut, 'threading', threading)

  assert sut._get_thread_context() in [
        -6805948436281256182, # Python >= 3.9
        3713141171098444831, # Python < 3.9
    ]
E       assert 1692341442 in [-6805948436281256182, 3713141171098her444831]
E        +  where 1692341442 = <function _get_thread_context at 0xf6894938>()
E        +    where <function _get_thread_context at 0xf6894938> = sut._get_thread_context

tests/test_dom_tag.py:20: AssertionError
=========================== short test summary info ============================
 FAILED tests/test_dom_tag.py::test___get_thread_context - assert 1692341442 i...

full log: here

[Knio]

Looks like you can just add 1692341442 to the set of ids... this is a very brittle test :(

[benalb]

Looks like you can just add 1692341442 to the set of ids... this is a very brittle test :(

That fixes the build un i686. Do you want me to make a PR with the change?

[Knio]

sure yeah, or if you have any ideas how to refactor this test

[benalb]

sure yeah, or if you have any ideas how to refactor this test

Sorry, no clue about that, will push the PR this weekend. I'm closing the issue. Thank you.