Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

fix(commit): fix missing body and footer message #579

Merged
merged 1 commit into from
Aug 30, 2021
Merged

fix(commit): fix missing body and footer message #579

merged 1 commit into from
Aug 30, 2021

Conversation

aspirantzhang
Copy link
Contributor

@aspirantzhang aspirantzhang commented Aug 29, 2021

Problem

The body and footer message missing in the commit message.

Reason

Use '\n' to add a new line doesn't work in the command line.

execa('git', ['commit', '-m', '"FirstRow\nSecondRow"']);

Reference

https://stackoverflow.com/questions/5064563/add-line-break-to-git-commit-m-from-the-command-line/

Solution

Use the -m parameter to separate multiple lines.

execa('git', ['commit', '-m', '"FirstRow"', '-m', '"SecondRow"']);

Breaking Change

quoteMessageInGitCommit option has been removed, because of unnecessary. New design must use quotation marks.

Snapshot

commit-snapshot

Closes #443, #527

body and footer message missing

remove quoteMessageInGitCommit option

BREAKING CHANGE: remove quoteMessageInGitCommit option

Closes #443, #527
Copy link
Owner

@KnisterPeter KnisterPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aspirantzhang Very nice 🚀 Thank you

@KnisterPeter KnisterPeter merged commit 8857f85 into KnisterPeter:master Aug 30, 2021
@KnisterPeter
Copy link
Owner

@shipjs prepare

@github-actions
Copy link

@KnisterPeter shipjs prepare done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why didn't I fill in the body and footer parts?
2 participants