Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment branch policies #1108

Merged
merged 7 commits into from
Mar 10, 2023
Merged

Deployment branch policies #1108

merged 7 commits into from
Mar 10, 2023

Conversation

SergkeiM
Copy link
Contributor

@SergkeiM SergkeiM commented Mar 9, 2023

  • added Deployment branch policies
  • Moved environments under deployment

@SergkeiM
Deployment branch policies
9734d23 
* added Deployment branch policies
* Moved environments under deployment
@SergkeiM
Copy link
Contributor Author

SergkeiM commented Mar 9, 2023

Hi @acrobat @Nyholm I promise this is the last PR :) for today, Just i'm building somethings that needs Deployments/Policies/Variables/Environments :)

acrobat
acrobat requested changes Mar 9, 2023
View reviewed changes
lib/Github/Api/Deployment/Policies.php Outdated Show resolved Hide resolved
lib/Github/Api/Deployment/Policies.php Outdated Show resolved Hide resolved
@SergkeiM SergkeiM requested a review from acrobat March 10, 2023 07:23
acrobat
acrobat approved these changes Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FROXZ can you rebase against the current master branch to resolve the pr conflicts? Thanks!

@SergkeiM
Copy link
Contributor Author

@acrobat I think I need to re-do the docs and put Policies and Env underDeployments? What you think?

@acrobat
Copy link
Collaborator

acrobat commented Mar 10, 2023

Sure, you can move those @FROXZ

@acrobat acrobat merged commit 00570ac into KnpLabs:master Mar 10, 2023
@acrobat
Copy link
Collaborator

acrobat commented Mar 10, 2023

Thank you @FROXZ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acrobat acrobat acrobat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SergkeiM @acrobat