Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BC check on 3.x #900

Merged
merged 2 commits into from Jul 4, 2020
Merged

Remove BC check on 3.x #900

merged 2 commits into from Jul 4, 2020

Conversation

GrahamCampbell
Copy link
Contributor

Can be added back once 3.0.0 is tagged.

@acrobat
Copy link
Collaborator

acrobat commented Jul 4, 2020

Maybe it's better to set it as an allow_failure in travis until v3 is released. On the other hand we use a feature like Roave/BackwardCompatibilityCheck#81

@GrahamCampbell
Copy link
Contributor Author

Maybe we could comment it out in the travis file, to try and make sure it's not forgotten about. That's what Guzzle did during Guzzle 7 development. Alternatively, I could always open a PR to revert this one marked as draft, so it's nor forgotten?

I'd be against setting to allow failure on the grounds that it's a waste of electricity to run the job.

@acrobat
Copy link
Collaborator

acrobat commented Jul 4, 2020

Comment it out in this PR and add a small comment above why it's commented and indeed open a draft PR to revert. I will set the milestone to 3.0 for that draft pr so we can revert it around/after the release!

@GrahamCampbell
Copy link
Contributor Author

Done. :)

@GrahamCampbell
Copy link
Contributor Author

Once this is merged, I'll rebase the PSR-17 PR, so we can see a passing build. 🎉

@acrobat acrobat merged commit 4096222 into KnpLabs:master Jul 4, 2020
@acrobat
Copy link
Collaborator

acrobat commented Jul 4, 2020

Thank you @GrahamCampbell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants