Update hvacThermostat attributes + invalid value handling #5892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most important change is NOT to return 0 in case invalid value is returned. Second change is to detect invalid values differently: according to ZCL spec rev8, the valid range for most of the hvacThermostat attributes is 0x954d – 0x7fff. The lower bound translates to -27315 (-273.15 respectivelly). Invalid value for sint16 is 0x800. The change updates the threshold for invalid value detection from -250 to -273.15.
tomasbedrich
changed the title
Koenkk
reviewed
Jun 19, 2023
tomasbedrich
force-pushed
the
update-hvac-thermostat
branch
from
cac6aa3
to
4fa8f7d
Compare
|
As part of some future refactor, I'd propose creating an abstraction layer on top of Zigbee type parsing – to handle the invalid cases on a single place. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review per-commit.
localTemperatureis so common (ZCL mandatory) that hopefully no/very-little devices returns invalid values.0can easily be a valid value for these attributes and by converting invalid values to0we loose the information. The subject of discussion is ifnullis the right value to return in this case.Your thoughts are welcome.