Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for phoscon hive #5902

Merged
merged 5 commits into from
Jun 27, 2023
Merged

add support for phoscon hive #5902

merged 5 commits into from
Jun 27, 2023

Conversation

Backup7750
Copy link
Contributor

please review, this is my first addon for zigbee2mqtt and my first commit in github. (worked for me as external addon in zigbee2mqtt)

please review, this is my first addon for zigbee2mqtt and my first commit in github. (worked for me as external addon in zigbee2mqtt)
model: 'Hive',
vendor: 'Phoscon',
description: 'Battery powered smart LED light',
extend: extend.light_onoff_brightness_colortemp_color(),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the physical color temp range to phoscon Hive
Read result of 'lightingColorCtrl': {"colorTempPhysicalMin":153,"colorTempPhysicalMax":370}
@Backup7750
Copy link
Contributor Author

Backup7750 commented Jun 25, 2023

How can I add also the Power to the Template with the extend method?

i can read out the following function via Zigbee2mqtt
Read result of 'genPowerCfg': {"batteryPercentageRemaining":80}

updates are also possible via the dresten electronic page
https://github.com/dresden-elektronik/deconz-rest-plugin/wiki/OTA-Image-Types---Firmware-versions#dresden-elektronik

Koenkk added a commit to Koenkk/zigbee-OTA that referenced this pull request Jun 25, 2023
@Koenkk
Copy link
Owner

Koenkk commented Jun 25, 2023

Updated the code to add this, please check if it works (https://github.com/Koenkk/zigbee-herdsman-converters/pull/5902/files)

@Backup7750
Copy link
Contributor Author

got the same error like in ci. zigbee2mqtt will not start.

/app/node_modules/zigbee-herdsman-converters/index.js:58
assert.fail('${definition.model}' has configure in extend and device, this is not allowed);
^
AssertionError [ERR_ASSERTION]: 'Hive' has configure in extend and device, this is not allowed
at Object.addDefinition [as addDeviceDefinition] (/app/node_modules/zigbee-herdsman-converters/index.js:58:20)
at new ExternalConverters (/app/lib/extension/externalConverters.ts:15:17)
at new Controller (/app/lib/controller.ts:84:58)
at start (/app/index.js:106:18)

but can check this only as external converter.

@Koenkk
Copy link
Owner

Koenkk commented Jun 25, 2023

Fixed that, updated the code

@Backup7750
Copy link
Contributor Author

battery and lamp works fine now. Thanks a lot!
but device does not appear in update list.

@Koenkk
Copy link
Owner

Koenkk commented Jun 27, 2023

What do you mean with "update list"?

@Backup7750
Copy link
Contributor Author

in the panel "OTA" All devices are shown up which can be updated then you can search for firmware there.
what can I do to check if an update for this device is available if not in that "list"?

@Koenkk
Copy link
Owner

Koenkk commented Jun 27, 2023

Are you sure you added the ota: ota.zigbeeOTA, line? If this is present it will show up under OTA updates.

@Backup7750
Copy link
Contributor Author

okay this line i missed. now it works... my fault :D

@Koenkk Koenkk merged commit ba89faf into Koenkk:master Jun 27, 2023
1 check passed
@Koenkk
Copy link
Owner

Koenkk commented Jun 27, 2023

Thanks!

@Backup7750
Copy link
Contributor Author

welcome
and a big thank you to you and this great project and the great support for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants