feat: Add rotation data to Philips Hue Tap Dial #6321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Oct 22, 2023
src/lib/philips.ts
Outdated
| const adjustedTime = direction === 'right' ? time : 256 - time; | ||
| const dialType = 'rotate'; | ||
| const speed = adjustedTime <= 25 ? 'step' : adjustedTime <= 75 ? 'slow' : 'fast'; | ||
| payload.action = `${button}_${dialType}_${direction}_${speed}`; | ||
| payload.time = adjustedTime; | ||
| payload.direction = direction; | ||
| payload.type = type; |
There was a problem hiding this comment.
Please prefix these with action, e.g. action_direction
Koenkk
reviewed
Oct 22, 2023
Koenkk
reviewed
Oct 25, 2023
src/lib/exposes.ts
Outdated
| @@ -615,6 +615,9 @@ export const presets = { | |||
| // Specific | |||
| ac_frequency: () => new Numeric('ac_frequency', access.STATE).withLabel('AC frequency').withUnit('Hz').withDescription('Measured electrical AC frequency'), | |||
| action: (values: string[]) => new Enum('action', access.STATE, values).withDescription('Triggered action (e.g. a button click)'), | |||
| action_type: (values: string[]) => new Enum('action_type', access.STATE, values).withDescription('Type of the rotation, value in the first message is `step` and in the next messages value is `rotate`'), | |||
There was a problem hiding this comment.
It is not needed to put them here as these are not generic, so in the definition exposes use e.g.
e.enum('action_type', access.STATE, ['step', 'rotate']).withDescription('Type of the rotation, value in the first message is `step` and in the next messages value is `rotate`')
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Philips Hue Tap Dialswitch. This enables more precise automation controls as it exposes the data about the rotation.time,direction,type