Namron 4512761 #6573
Merged
Namron 4512761 #6573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for namron 4512761
thordy
reviewed
Nov 27, 2023
src/devices/namron.ts
Outdated
| configure: async (device, coordinatorEndpoint, logger) => { | ||
| const endpoint = device.getEndpoint(1); | ||
| await reporting.bind(endpoint, coordinatorEndpoint, ['genBasic', 'genOnOff', 'haElectricalMeasurement', 'seMetering']); | ||
| await endpoint.read('haElectricalMeasurement', ['acVoltageMultiplier', 'acVoltageDivisor']); |
There was a problem hiding this comment.
I would suggest switching to use the convenience method readEletricalMeasurementMultiplierDivisors instead of reading each of these.
This also doesn't report any power consumption (for me at least), so you should also add readMeteringMultiplierDivisor, leaving the final configure as
configure: async (device, coordinatorEndpoint, logger) => {
const endpoint = device.getEndpoint(1);
await reporting.bind(endpoint, coordinatorEndpoint, ['genBasic', 'genOnOff', 'haElectricalMeasurement', 'seMetering']);
await reporting.readEletricalMeasurementMultiplierDivisors(endpoint);
await reporting.readMeteringMultiplierDivisor(endpoint);
await reporting.onOff(endpoint);
},
That successfully reports Power, Voltage, Current, and Energy.
@enrawi will you update your PR, or want me to submit a new one?
There was a problem hiding this comment.
Thx. I've had this running for 3 weeks now with no problems. But this is the first time for me :)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for namron 4512761