Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendor information #6911

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Update vendor information #6911

merged 2 commits into from
Jan 16, 2024

Conversation

NikitaKorneev
Copy link
Contributor

This change is supposed to indicate real manufacturer of the devices in the converter file.

To clarify

WB-MSW-ZIGBEE v.4 and WB-MSW-ZIGBEE v.3 sensors are products of Wirenboard company, and not a Sprut company.

Wirenboard is a Russian-based hardware company that makes industrial-grade controllers and sensors.

Sprut is a Russian-based company that makes smart-home hubs for local smart home system deployment. Their hubs have zigbee coordinator.

I assume Sprut employees wrote the original converter to make Wirenboard's devices work with their hardware as maybe their back-end is z2m. But I assure you - the two sensors mentioned in the original file are made by Wirenboard company.

I couldn't find them in the supported devices list on z2m website using Wirenboard and I hope this change will make it less confusing.

These two sensors are the product of a company named Wirenboard, and not a Sprut company. Here are related URLs

https://wirenboard.com/en/catalog/sensors/
Replace sprut with wirenboard
@NikitaKorneev NikitaKorneev marked this pull request as ready for review January 15, 2024 21:07
@sjorge
Copy link
Sponsor Contributor

sjorge commented Jan 16, 2024

We should probably still have these as whiteLable under Sprut as that might be what people look them up under on the supported devices page.

(We have silimar issues with Xiaomi/Aqara/Maji devices, the are all made by LUMI, Frient devices which are just Develco but B2C instead of the usual B2B Develco does, ...)

@NikitaKorneev
Copy link
Contributor Author

NikitaKorneev commented Jan 16, 2024

are all made by LUMI

The thing is - Sprut company has absolutely nothing to do with these devices. They do not produce them, and do not interact with them in any way. These sensors are never mentioned on any of their resources except on the supported devices page.

might be what people look them up under on the supported devices page.

I got confused exactly because Wirenboard is not in the list of producers :) I purchased the sensor and red in their docks that it works with z2m but i could not find them in the list when searching by producer.

@sjorge
Copy link
Sponsor Contributor

sjorge commented Jan 16, 2024

Interesting

@Koenkk Koenkk merged commit 3206130 into Koenkk:master Jan 16, 2024
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Jan 16, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants