New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor improvements for Bosch BWA-1, BSD-2, BSEN-C2 & BSEN-CV #7386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where did that ! come from???
No `manufacturerOptions` used by BSD-2 when interacting with the `ssIasZone` cluster.
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following minor fixes for the aforementioned devices:
fz.battery
to BSEN-C2 & BSEN-CVssIasZone
&manuSpecificBosch11
from BWA-1ssIasZone
from BSD-2Reporting is not required for IAS (
ssIasZone
), insteadcommandStatusChangeNotification
is used to notify the coordinator. Attribute reporting is unnecessary for BSD-2 and BWA-1 because the respective attributes can't be changed outside of Z2M (e.g. on the device itself).While it initially seemed like BWA-1 requires
ssIasZone
to be bound, that's actually not the case. It just takes a minute or so, after pairing, for the device to be armed. Duh! 馃槄