feat(add): ZDMS16-1 and ZDMS16-2 Avatto dimmer switches #7398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Apr 15, 2024
| ], | ||
| meta: { | ||
| multiEndpoint: true, | ||
| tuyaDatapoints: [ |
There was a problem hiding this comment.
Data points seem to be the same as TS0601_dimmer_4, can you confirm and add it as a tuya.whitelabel to TS0601_dimmer_4?
There was a problem hiding this comment.
hi, it's not. the new one doesn't support lightType and uses endpoint 4 and 8 for switchType.
also the switchType enum has a different mapping.
Koenkk
reviewed
Apr 15, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here: Koenkk/zigbee2mqtt#22175
Aliexpress page: https://it.aliexpress.com/item/1005006523496245.html
These dimmers uses different enum values for switchType comparing to standard tuya dimmers, so a new tuya converter (switchType2) has been introduced in lib/tuya.ts