Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZigbeeTLc firmware devices support #7457

Merged
merged 5 commits into from
May 1, 2024
Merged

Conversation

robvanoostenrijk
Copy link
Contributor

Add support for the pvvx ZigbeeTLc custom firmware devices.

This custom firmware is available for several temperature / humidity sensors:

This device file supports all above variants (display + comfort, display and no display).
Note it requires ZigbeeTlc firmware v0.1.2.1 or higher.

src/devices/zigbeetlc.ts Outdated Show resolved Hide resolved
src/devices/zigbeetlc.ts Outdated Show resolved Hide resolved
src/devices/zigbeetlc.ts Outdated Show resolved Hide resolved
@robvanoostenrijk
Copy link
Contributor Author

Updated taking into account the review feedback.

src/devices/zigbeetlc.ts Outdated Show resolved Hide resolved
{modelID: 'TH03Z-z', manufacturerName: 'Tuya'},
{modelID: 'TH03Z-bz', manufacturerName: 'Tuya'},
],
model: 'WSD500A',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
model: 'WSD500A',
model: 'WSD500A_1',

WSD500A is already in use so I guess this makes the most sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This a custom firmware for exactly those devices. The ZigbeeTLc firmware vastly improves the devices performance and reporting characteristics.

The same logic applies to the LYWSD03MMC model in the converter as well.

Keeping the above in mind, would you still like to have a model suffix for the same physical device but with different firmware? The Zigbee IDs are suffixed with (-z and -bz) for the custom firmware compared to the default already.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because the model should be unique for every device.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the duplicate models with custom ZigbeeTLc support to use an unique model name (suffix -z, same as the ZigbeeModel)

@Koenkk Koenkk merged commit cb6dd3e into Koenkk:master May 1, 2024
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented May 1, 2024

Thanks!

@pvvx
Copy link

pvvx commented May 2, 2024

Yes, because the model should be unique for every device.

All firmware v0.1.2.1 supports changing the device name by the user.
How to work with Z2M with two devices with the same name and different FW versions and functions? This is also found in Tuya variants.

Each Zigbee device has a firmware version number, HW number, and manufacturer number.
Changing the device name does not create any problems with Zigbee OTA and working with software that supports Zigbee 3.0. Binding and working on the Zigbee network occurs by device MAC, and not by name.

@IamHEREfromU
Copy link

my xiaomi LYWSD03MMC have the FM version 2.1.1_0159 how can i flash to the Firmware to run on my HA? bcs now the HA ask for a Blindkey and i dont have it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants