Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ID checks for scene/group #7529

Merged
merged 1 commit into from
May 18, 2024
Merged

Fix ID checks for scene/group #7529

merged 1 commit into from
May 18, 2024

Conversation

Nerivec
Copy link
Contributor

@Nerivec Nerivec commented May 17, 2024

From Zigbee spec:

3.7.2.4.1 Generic Usage Notes
Scene identifier 0x00, along with group identifier 0x0000, is reserved for the global scene used by the OnOff cluster.

Since Philips devices appear to require usage of scene ID zero with non-zero group IDs, I'm assuming the spec has to be interpreted that way, and not just "prevent usage of scene ID zero".

Also got rid of a few more hasOwnProperty that don't check for undefined.

@Koenkk Koenkk merged commit 92b9918 into Koenkk:master May 18, 2024
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented May 18, 2024

Thanks!

@Nerivec Nerivec deleted the fix-scene-id branch May 18, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants