Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cluster.ts #1116

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Update cluster.ts #1116

merged 4 commits into from
Jul 16, 2024

Conversation

turboproc
Copy link
Contributor

Adding support for PM1 and PM10 clusters, and, changing attribute types to single.

More detail:

  • Zigbee cluster definition specifies all attributes that belong to PM2 cluster as single (not INT16). See 4.13.2.1
  • Zigbee cluster definition does not specify the PM1 and PM10 clusters. However considering that Zigbee cluster definition and Matter cluster definition follow each other 1:1, it seems fairly safe to use the Matter cluster code points for PM1 and PM10.

@turboproc
Copy link
Contributor Author

Updated spacing to fix tab alignment issue

@turboproc
Copy link
Contributor Author

Updated tstype to reflect added clusters

@Koenkk Koenkk merged commit 802dfc1 into Koenkk:master Jul 16, 2024
1 check passed
@Koenkk
Copy link
Owner

Koenkk commented Jul 16, 2024

Thanks!

@Koenkk Koenkk mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turboproc @Koenkk