Adding new device RDZ100ZB

[VladislavVesely]

Hello,

i'm trying to add unsupported thermostat from Siemens. So far i got some basic stuff working by adding (please ignore unused parts or any ugly code used during debugging).

const {identify, battery, ota} = require('zigbee-herdsman-converters/lib/modernExtend');
const exposes = require('zigbee-herdsman-converters/lib/exposes');
const constants = require('zigbee-herdsman-converters/lib/constants');
const reporting  = require('zigbee-herdsman-converters/lib/reporting');
const fz = require('zigbee-herdsman-converters/converters/fromZigbee');
const tz = require('zigbee-herdsman-converters/converters/toZigbee');
const e = exposes.presets;
const ea = exposes.access;
const payload = reporting.payload;
const repInterval = constants.repInterval;


//export const test = async (endpoint: Zh.Endpoint, overrides?: Reporting.Override) => {
//    const p = payload('ctrlSeqeOfOper', 10, repInterval.HOUR, null, overrides);
//    await endpoint.configureReporting('hvacThermostat', p);
//};

const definition = {
    zigbeeModel: ['RDZ100'],
    model: 'RDZ100',
    vendor: 'Siemens',
    description: 'Siemens RDZ100 Wireless Thermostat',
    fromZigbee: [
        fz.thermostat,
    ],
    toZigbee: [
        tz.thermostat_local_temperature,
	tz.thermostat_local_temperature_calibration,
        tz.thermostat_occupied_heating_setpoint,
	tz.thermostat_unoccupied_heating_setpoint,
        tz.thermostat_system_mode,
    ],
    extend: [identify(), battery(), ota()],
    exposes: (device, options) => {
	const expose = [
	    e.climate()
	    .withLocalTemperature()
	    .withLocalTemperatureCalibration(-2.5, 2.5, 0.5)
	    .withSetpoint('occupied_heating_setpoint', 5, 30, 0.5)
	    .withSetpoint('unoccupied_heating_setpoint', 5, 30, 0.5)
	    .withSystemMode(['off', 'heat'])
	];
	
	expose.push(e.enum('ctrlSeqeOfOper', ea.STATE_SET, ['0', '1', '2', '3', '4']).withDescription('TODO'));

	return expose;
    },
    meta: {timeout: 100000},
    configure: async (device, coordinatorEndpoint) => {
        const endpoint = device.getEndpoint(1);

	await reporting.bind(endpoint, coordinatorEndpoint, ['genPowerCfg', 'hvacThermostat']);
        await reporting.thermostatTemperature(endpoint);
        await reporting.thermostatOccupiedHeatingSetpoint(endpoint);
        await reporting.thermostatUnoccupiedHeatingSetpoint(endpoint);
    },
};

It's working as expected but i have two questions:
1] All write operations works only few seconds after the device reported something. Should i set longer timeout, or is there a better way how to handle this?
2] There is already some enum and mapping for ctrlSeqeOfOper (cooling_only, cooling_with_reheat, etc...) what is the best way to handle this? Custom handler directly in that device class for both read / write? Any example?
3] I noticed that all stuff in repo are TS, do i have to use JS to define the device?

Thanks a lot.

[VladislavVesely]

Points 2] 3] resolved

But still i do not know what is the best way how to handle write which does time out before i'll receive something from the device.

[Koenkk]

1. Is it detected as and end device? If yes that's expected

[Koenkk]

Could you provide the debug log of:

• 5 minutes of doing nothing
• send request
• 5 minutes after this

[VladislavVesely]

Now it seems to be working as expected. Probably some part of configuration originally failed, there was no reporting configuration at all.

Thanks a lot for the support. One more thing. Is there way how to set common metadata for all write / read operations, so i can use just generic methods instead of copy pasting everything just to change the meta?

Setting meta directly on root object does not seem to be doing anything.

Also do you think is worth of having this queue also for read operation?

EDIT: Or maybe not... i left the device and z2m for a while without making any changes. Tested the scenario again and see, that there is no queue in the log again. As if it does ignored the pending request timeout :/

[Koenkk]

We could add that to utils.getOptions which is used a lot already in toZigbee.

[VladislavVesely]

I meant it more generally, so we do not have to copy paste thermostat_system_mode just to add sendPolicy. I'm not sure how common it is for other implementations to be so close to original that only meta is different.

Btw what is the best process now to submit the device? In the doc you mentioned using JS, but whole repo is in TS. Is there a way how to test it from TS directly?

[Koenkk]

I meant it more generally, so we do not have to copy paste thermostat_system_mode just to add sendPolicy. I'm not sure how common it is for other implementations to be so close to original that only meta is different.

Maybe I don't understand you, but this is exactly what utils.getOptions does

Btw what is the best process now to submit the device? In the doc you mentioned using JS, but whole repo is in TS. Is there a way how to test it from TS directly?

You can submit a PR, for the definition part there is no diff between ts and js.