Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added icon and device_class for some Aqara device entities #20746

Merged
merged 7 commits into from
Jan 17, 2024

Conversation

mrskycriper
Copy link
Contributor

@mrskycriper mrskycriper commented Jan 11, 2024

Added icon and device_class for secondary entities of these Aqara devices:

SRTS-A01 (Smart Radiator Thermostat E1)

  • setup with device_class: 'running'
  • valve_alarm with device_class: 'problem'
  • window_open with device_class: 'window'
  • valve_detection with icon: 'mdi:pipe-valve'
  • window_detection with icon: 'mdi:window-open-variant'
  • sensor_temp with icon: 'mdi:thermometer'
  • sensor with icon: 'mdi:tune'
  • calibrate with icon: 'mdi:tune'

SP-EUC01 (EU smart plug)

  • auto_off with icon: 'mdi:flash-auto'
  • overload_protection with icon: 'mdi:flash'

RTCGQ14LM (P1 human body movement and illuminance sensor)

  • trigger_indicator with icon: 'mdi:led-on'
  • detection_interval with icon: 'mdi:timer'

WS-EUK01 (Smart wall switch H1 EU (no neutral, single rocker))

  • mode_switch with icon: 'mdi:tune'

Almost all Aqara devices

  • power_outage_count with icon: 'mdi:counter'

@mrskycriper mrskycriper changed the title Update entity_category for some Aqara devices Update entity_category for some Aqara device entities Jan 11, 2024
@sjorge
Copy link
Sponsor Contributor

sjorge commented Jan 12, 2024

This can be set on the expose data now, e.g. power_outage_count got it updated in this change Koenkk/zigbee-herdsman-converters@2c08cdc#diff-5ec1d2e171ffffe0fed4b8c16747c7db4925aa15553a4c9fa8d71bbb2c45bf6aR741

@Koenkk
Copy link
Owner

Koenkk commented Jan 13, 2024

@sjorge you are right, @mrskycriper please use the withCategory on the expose instead (icon can stay in this PR)

@mrskycriper
Copy link
Contributor Author

Thanks for clarifications @sjorge @Koenkk , I'll update the PR later and make a new one in zigbee-herdsman-converters. Also, should I leave device_class here or is there a better way to change it?

@Koenkk
Copy link
Owner

Koenkk commented Jan 13, 2024

device_class can be kept here.

@mrskycriper mrskycriper changed the title Update entity_category for some Aqara device entities Added icon and device_class for some Aqara device entities Jan 16, 2024
@mrskycriper
Copy link
Contributor Author

mrskycriper commented Jan 17, 2024

@Koenkk I've removed all mentions of entity_category from this PR. However, I can't seem to make the necessary changes in the converter. I've copied existing converter for SRTS-A01 into external converter for testing, but no changes ever apply to the device. I've reset, reconfigured and restarted everything multiple times to no avail. Am I missing something?

@Koenkk Koenkk merged commit ac74fac into Koenkk:dev Jan 17, 2024
8 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Jan 17, 2024

@mrskycriper can you try changing the description and see if it is reflected in the z2m frontend?

@mrskycriper
Copy link
Contributor Author

@Koenkk that is the strange part, absolutely no reaction on any change in descriptions. As if the external converter doesn't exist

@Koenkk
Copy link
Owner

Koenkk commented Jan 17, 2024

Did you add it to your z2m configuration.yaml or do you see an error message about loading the external converter at startup?

@mrskycriper
Copy link
Contributor Author

@Koenkk found it in the logs and fixed the imports. Now it kinda works, but the custom local fromZigbee and toZigbee converters need a custom type Buffer and it looks looks like external converter doesn't have the necessary npm package in its environment. And without it I cant test the functionality of re-categorized controls, mentioned here

@mrskycriper
Copy link
Contributor Author

Created PR for continued discussion Koenkk/zigbee-herdsman-converters#6922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants