Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'occupancy' device_class instead of 'motion' for occupancy sensors #22896

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

agoode
Copy link
Contributor

@agoode agoode commented Jun 2, 2024

'occupancy' matches the zigbee terminology more closely and is more consistent with other Home Assistant entities of this type.

https://www.home-assistant.io/integrations/binary_sensor/

In general, it looks like 'motion' is more for alarms, and 'occupancy' for non-alarm situations. Z2M currently makes no distinction between these concepts, but they could be separated (with a fair amount of work).

'occupancy' matches the zigbee terminology more closely and is more
consistent with other Home Assistant entities of this type.

https://www.home-assistant.io/integrations/binary_sensor/

In general, it looks like 'motion' is more for alarms, and 'occupancy'
for non-alarm situations. Z2M currently makes no distinction between
these concepts, but they could be separated (with a fair amount of work).
@Koenkk Koenkk merged commit 519e123 into Koenkk:dev Jun 2, 2024
11 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Jun 2, 2024

Thanks!

@agoode agoode deleted the occupancy branch June 3, 2024 00:14
ghoz pushed a commit to ghoz/zigbee2mqtt that referenced this pull request Jun 14, 2024
… sensors (Koenkk#22896)

'occupancy' matches the zigbee terminology more closely and is more
consistent with other Home Assistant entities of this type.

https://www.home-assistant.io/integrations/binary_sensor/

In general, it looks like 'motion' is more for alarms, and 'occupancy'
for non-alarm situations. Z2M currently makes no distinction between
these concepts, but they could be separated (with a fair amount of work).
@nikrays
Copy link

nikrays commented Jul 3, 2024

put everything back, now the motion sensor shows the "house" icon instead of the "running man"!

@agoode
Copy link
Contributor Author

agoode commented Jul 3, 2024

Yes, unfortunately there is not currently a separate category for "occupancy" vs "motion" in z2m. It would be more work to add this.

You can always override the type in Home Assistant, see https://www.home-assistant.io/docs/configuration/customizing-devices/

@nikrays
Copy link

nikrays commented Jul 3, 2024

Yes, unfortunately there is not currently a separate category for "occupancy" vs "motion" in z2m. It would be more work to add this.

You can always override the type in Home Assistant, see https://www.home-assistant.io/docs/configuration/customizing-devices/

so this is a temporary solution? Maybe I don’t need to change anything yet? Does this require some work on your part or on the home assistant side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants