Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!! Major Cipher issue !! #100

Closed
KoljaWindeler opened this issue May 19, 2021 · 8 comments
Closed

!! Major Cipher issue !! #100

KoljaWindeler opened this issue May 19, 2021 · 8 comments
Labels
bug Something isn't working

Comments

@KoljaWindeler
Copy link
Owner

Hi everyone, I'm writing this because I get multiple bug reports via all channels I can think of, even my wife complained in person :D. YouTube changed the way how the streaming data are pushed to the client and this results in major issues at the moment.

As of now the decoding way works like this:

Init

  1. create a PyTube instance
  2. feed a YouTube (! not YouTube music) page to PyTube to load the javascript and parse the decipher algorithm

For every song

  1. Request the streaming data (Url + ciphered signature) via ytubemusicapi
  2. Let PyTube decipher the signature
  3. Join url + sig and push that to the player
  4. if the procedure above fails (which it never did), push the videoId to PyTube and see if it can find the link

Usually step 4 never ran. It's more like a backup ... it works, but not for all songs and it is also a lot slower.
After youtube changed the backend the streamingData for step 1 above were no longer present (#97). sigma67 (author of the fabulous backend) fixed this quickly, but the newly presented streamingData work 'differently' .. at least the usual way to decipher them isn't working anymore.

So with release https://github.com/KoljaWindeler/ytube_music_player/tree/20210517b01 every request uses step 4. Some video/music links are NOT decodable this way. the player will accept up to 3 fails in a row before giving up. I've seen on my setup that the player has to skip quite a few songs and sometime even stops completely (after 3 fails).

Currently that's where we are. I'm very unhappy and keep working on a solution but this could take some time. Any help is appreciated.
Kolja

@KoljaWindeler KoljaWindeler added the bug Something isn't working label May 19, 2021
@Zeunas
Copy link

Zeunas commented May 19, 2021

Does this also relates to the fact that now we can only play public playlists not private playlist from uploaded Albums/Songs?

@KoljaWindeler
Copy link
Owner Author

jep

@DravenSA
Copy link

Is there any error codes we can send, or is it all generic at this moment?

@slankes
Copy link

slankes commented May 19, 2021

As the production version is completly broken now (at least for me) - what do you think about promoting your beta to "stable". I'd say that it cannot get worse ...

@KoljaWindeler
Copy link
Owner Author

some good news ahead of time but it looks like the issue is fixed. I'm just waiting for sigma to publish a new release. I've verified here with the git-master and its working just fine .. just a little more patience :D

@KoljaWindeler
Copy link
Owner Author

Fixed with https://github.com/KoljaWindeler/ytube_music_player/releases/tag/20200519.01

@KoljaWindeler
Copy link
Owner Author

Currently it's broken again .. working on it

@KoljaWindeler KoljaWindeler reopened this May 21, 2021
@KoljaWindeler
Copy link
Owner Author

Seems to be working now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants