Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected item on TV Show non-visible #1569

Closed
2 of 4 tasks
regorxxx opened this issue May 2, 2023 · 6 comments · Fixed by #1570
Closed
2 of 4 tasks

Selected item on TV Show non-visible #1569

regorxxx opened this issue May 2, 2023 · 6 comments · Fixed by #1570
Assignees
Labels
Milestone

Comments

@regorxxx
Copy link

regorxxx commented May 2, 2023

Describe the bug
When an item is selected, colors are not set properly, thus becoming non-visible (either the item or the selection).

To Reproduce
Steps to reproduce the behavior:

  1. Go to TV Shows
  2. Click on any item (Show, season or episode).

Expected behavior
Follow the same behavior than other items at other tabs.

Screenshots
Light UI, item becomes invisible
image

Dark UI, no selection is shown
image

MediaElch Version:

  • 2.10.0 stable

Operating System:

  • Windows
  • macOS
  • Linux (distribution: .)

Additional context
Windows 7

@regorxxx regorxxx changed the title Selected item on TV Show using background color Selected item on TV Show non-visible May 2, 2023
@bugwelle
Copy link
Collaborator

bugwelle commented May 2, 2023

Thanks. Noticed this locally as well, but forgot about it. This happens because we use the system's color there, even if the background color does not match.

@bugwelle bugwelle added this to the v2.10.2 milestone May 2, 2023
@bugwelle bugwelle self-assigned this May 2, 2023
@bugwelle
Copy link
Collaborator

bugwelle commented May 2, 2023

Oh, that's not it. The background effect is missing! I'll look into it.

@regorxxx
Copy link
Author

regorxxx commented May 2, 2023

Yep, it's both.

And depending on the UI mode it makes either impossible to know where is the current selection or the text of the selected item. Glad you also reproduced it. Thanks ;)

@bugwelle
Copy link
Collaborator

bugwelle commented May 4, 2023

Screenshot 2023-05-04 at 17 33 51

This is how it looks like for macOS and is what I expected. For some reason, it doesn't work (anymore?) on Linux and Windows.

@bugwelle
Copy link
Collaborator

bugwelle commented May 4, 2023

Thanks for reporting. I figured out how to fix it. #1570 fixes your issue. A new snapshot version will be available in the next ~1h.

Please let me know if the new version has other issues (I know there are a few for the dark mode; that needs to fixed as well)

@regorxxx
Copy link
Author

regorxxx commented May 4, 2023

Selection works fine now in both modes. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants