Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong age rating from TMDB #1641

Closed
3 tasks done
Metal-Snake opened this issue Sep 3, 2023 · 1 comment · Fixed by #1642
Closed
3 tasks done

Wrong age rating from TMDB #1641

Metal-Snake opened this issue Sep 3, 2023 · 1 comment · Fixed by #1642
Assignees
Milestone

Comments

@Metal-Snake
Copy link

Metal-Snake commented Sep 3, 2023

Scrapers that don't work:

  • TMDb

Details which are wrong / not loaded:
Age rating

MediaElch Version:

  • 2.10.4 stable

Operating System:

  • macOS

Additional context:
I have MediaElch set to german, yet it loads a foreign age restriction for some movies.
Movie: The Rescuers
German name: Bernard & Bianca - Die Mäusepolizei

It loads the age restriction "U", at TMDB this is set for one french and two UK releases.

I guess it's because one release is set to 0 and one to nothing?
It should load the 0.

https://www.themoviedb.org/movie/11319-the-rescuers/releases
Bildschirmfoto 2023-09-03 um 20 46 47

SCR-20230903-sra

Some other movies where this happens:
The Silence of the Lambs
Der Untergang
Leon: The Professional

@bugwelle
Copy link
Collaborator

bugwelle commented Sep 7, 2023

Hi,

yes, we fall back to US and GB in case the preferred language was not found. In your case, it's GB (because there is no non-empty entry for US):

    {
      "certification": "U",
      "descriptors": [],
      "iso_3166_1": "GB",
      "primary": false,
      "release_date": "1977-10-14"
    },

But in your case, there are entries for DE. Thanks for reporting it!

The issue was that we only stored the last certification entry for a given language. However, there could be many entries for a language, not just one. And if the last one has a certification that is empty (not set), it won't be used.

I've fixed it locally and will push it soon. When the fix is pushed, a new nightly version will be available in ~1h.
I've added a test case to avoid any regressions in the future.

Thanks for reporting!

Regards,
Andre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants