Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images not saved #561

Closed
nkatsidis opened this issue Aug 25, 2018 · 14 comments
Closed

Images not saved #561

nkatsidis opened this issue Aug 25, 2018 · 14 comments
Labels
Milestone

Comments

@nkatsidis
Copy link

nkatsidis commented Aug 25, 2018

Mediaelch latest windows

I have many movies with previous accepted by kodi images with filenames:

  • disc.png
  • clearart.png
  • etc

I have defined in medialech in scraper
<baseFileName>-clearart.png

but if Medialech finds clearart.png that is saved locally, by pressing save it does not create <baseFileName>-clearart.png

with movies that are scraped for the first time this does not happen.
it only happens with previously saved movies where images already exist.

@bugwelle
Copy link
Collaborator

bugwelle commented Sep 3, 2018

Thanks for reporting this. I'm a bit late to answer but I'll try my best:

If I've understood you correctly, you have different files in a movie folder (movie, poster, clearart, etc).
If you click "Save", MediaElch should rename the poster, etc?

MediaElch does not rename existing files unless told to. We have a feature called "Renamer" which is inteded for exactly that use case. See: https://mediaelch.github.io/mediaelch-doc/renaming.html

Please let me know if this helps. :-)

@nkatsidis
Copy link
Author

nkatsidis commented Sep 3, 2018

No i dont want the existing files to be renamed.
its just that mediaelch does not create lets say Movie-clearart.png if clearart.png exists
same for disc etc

although i have set for I have defined in in scraper
<baseFileName>-clearart.png to be created

@nkatsidis
Copy link
Author

can you please check?

@bugwelle
Copy link
Collaborator

can you please check?

Sorry, forgot about this issue :)

its just that mediaelch does not create lets say Movie-clearart.png if clearart.png exists same for disc etc

ok. I'm unsure on how we should handle this. I'll come back to you because I found another bug that is related to your issue:

Given following structure:

12 years a slave
 |- logo.png
 |- movie.mov
  1. Scrape 12 years a slave (The Movie Db)
  2. Save movie
  3. No movie-logo.png was created (this is actually expected, at least to my understanding)
  4. Click on the Logo and select another one
  5. Bug: Instead of the selected logo, the placeholder is shown. logo.png is not updated as well.

Thank you for reporting this. :)

@nkatsidis
Copy link
Author

Any news on this?

@bugwelle
Copy link
Collaborator

bugwelle commented Oct 6, 2018

Sorry, no. I don't have much time at the moment for MediaElch. Furthermore I can't seem to reproduce the bug even though I wrote down the steps to reproduce it. :-/

@nkatsidis
Copy link
Author

I see that you are back :)
can i provide any more info about this issue?

@bugwelle
Copy link
Collaborator

I'm sorry that it took me so long to answer. Most of my current contributions are bugfixes or changes related to publishing the next release.

I don't think that this issue will be fixed in the next version. I plan on refactoring a lot of code which will hopefully make it easier to identify the cause of this.

@nkatsidis
Copy link
Author

thank you

@dirtkael
Copy link

Hello,
2 adds on this bug :
1- All movies in the same folder have the same files logo.png, disc.png, clearart.png, there is no naming of those files depending on the movie name.
image

2- in the parameters, if you specify that you don't want logo, disc art or clear art ... it does nothing, these files continue be created.
image

I use MediaElch 2.6.0 stable for windows
I hope I'm clear, I'm french and not that fluent in english anymore.

@dirtkael
Copy link

dirtkael commented Aug 16, 2019

OK, After more tests, you can forget about the first point.

I didn't change the settings about logo, clear art and disc art.
Those are not set initially like the others. They miss "<baseFileName>-" in it.
That's for the first point.
About the second one ... It still doesn't work like it should.

Thanks for reading :)

@bugwelle
Copy link
Collaborator

Hi there,

sorry for the late answer. I haven't looked into this issue again but will most likely do that next week. I haven't forgotten about this issue :)

@bugwelle bugwelle added this to the v2.6.2 milestone Aug 27, 2019
@bugwelle bugwelle modified the milestones: v2.6.2, v2.6.4 Sep 4, 2019
@bugwelle bugwelle modified the milestones: v2.6.4, v2.6.6 Feb 8, 2020
@bugwelle
Copy link
Collaborator

bugwelle commented Apr 8, 2020

HI everyone,

I was not able to reproduce this issue and think that everything works as intended. But I may misunderstand the issues you are experiencing (maybe a language barrier?).

To summarize:
I have a movie with the following files:

Sintel (2010)
├── clearart.png
├── disc.png
├── logo.png
├── movie.mov
└── poster.jpg

My settings look like this:

Screenshot_20200408_162309

Steps I took:

  1. Reload all movies
  2. Click on Movie (which is marked "new")
    -> No poster, disc or clear art is visible. Nothing is shown. MediaElch ignores the existing files because they do not match the patterns (see screenshot).
  3. Scrape Movie with all details from TMDb
  4. Click "Save All"

The folder now contains the following files:

Sintel (2010)
├── clearart.png
├── disc.png
├── logo.png
├── movie-banner.jpg
├── movie-clearart.png
├── movie-disc.png
├── movie-landscape.jpg
├── movie.mov
├── movie.nfo
├── movie-poster.jpg
└── poster.jpg

=> All files without the movie- prefix were not changed.

The files are not used at all which contradicts the original issue if I understood you right.


@dirtkael I was not able to reproduce your second point. If I do not select any scraper for logos, discart, etc. in the custom movie scraper, none are downloaded or saved to disk. :-/

@bugwelle bugwelle modified the milestones: v2.6.6, v2.8 Apr 14, 2020
@bugwelle bugwelle modified the milestones: v2.7.0, v2.7.2 Dec 7, 2020
@bugwelle bugwelle modified the milestones: v2.8.2, v2.8.4 Dec 17, 2020
@bugwelle bugwelle removed this from the v2.8.4 milestone Jan 8, 2021
@bugwelle bugwelle added this to the v2.8.6 milestone Jan 8, 2021
@bugwelle bugwelle modified the milestones: v2.8.6, v2.8.8 Jan 21, 2021
@bugwelle bugwelle modified the milestones: v2.8.8, v2.8.10 Apr 26, 2021
@bugwelle bugwelle modified the milestones: v2.8.10, v2.8.14 May 6, 2021
@bugwelle bugwelle modified the milestones: v2.8.14, v2.8.16 Feb 6, 2022
@bugwelle bugwelle modified the milestones: v2.8.16, v2.6.18 Apr 10, 2022
@bugwelle bugwelle modified the milestones: v2.6.18, v2.16.20 Oct 20, 2022
@bugwelle bugwelle modified the milestones: v2.9.0, v2.9.2 Jan 21, 2023
@bugwelle
Copy link
Collaborator

The last point here was:

I was not able to reproduce this issue and think that everything works as intended. But I may misunderstand the issues you are experiencing (maybe a language barrier?).

I'm therefore closing this issue. Feel free to reply and I will reopen this issue.

@bugwelle bugwelle closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants