Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TheTVDb] Fix firstAired scraper; Allow IMDB id's with 8 digits #855

Merged
merged 4 commits into from Jan 3, 2020

Conversation

bugwelle
Copy link
Collaborator

@bugwelle bugwelle commented Jan 3, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 3, 2020

Codecov Report

Merging #855 into master will decrease coverage by <.01%.
The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #855      +/-   ##
=========================================
- Coverage    6.98%   6.98%   -0.01%     
=========================================
  Files         445     445              
  Lines       34175   34176       +1     
=========================================
  Hits         2387    2387              
- Misses      31788   31789       +1
Impacted Files Coverage Δ
src/scrapers/tv_show/TheTvDb/Search.cpp 0% <0%> (ø) ⬆️
src/scrapers/tv_show/TheTvDb/ShowParser.cpp 0% <0%> (ø) ⬆️
src/ui/movies/MovieMultiScrapeDialog.cpp 0% <0%> (ø) ⬆️
src/scrapers/tv_show/TheTvDb/EpisodeParser.cpp 0% <0%> (ø) ⬆️
src/data/ImdbId.cpp 57.89% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e952d6...119b668. Read the comment docs.

@bugwelle bugwelle merged commit 8a9d835 into Komet:master Jan 3, 2020
@bugwelle bugwelle deleted the imdb-id branch January 3, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants