Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

problems with images #968

Open
2 of 5 tasks
meeotch opened this issue Apr 30, 2020 · 5 comments
Open
2 of 5 tasks

problems with images #968

meeotch opened this issue Apr 30, 2020 · 5 comments
Labels
component: scraper component: TV shows TV shows, series, episodes

Comments

@meeotch
Copy link

meeotch commented Apr 30, 2020 •
edited

Describe the bug
Two issues with images (I can split them into separate bugs, if that's what they turn out to be):

  1. I grabbed the latest nightly in order to get the "higher res imdb actors" fix, but the actor images displayed when I scrape are still from tvdb, despite the TV scraper->actors setting being set to imdb.

  2. Currently, only poster, fanart, and banner art shows up in the sidebar. Clicking on any other category fails with "server replied: bad gateway".

To Reproduce
Steps to reproduce the behavior:
Set Prefs->TV scraper->actors to thetvdb.
Scrape a show, look at the results in the Extended tab, and the artwork sidebar.

Expected behavior
Expected actors from imdb, and all art to show up in the sidebar.

Screenshots
If applicable, add screenshots to help explain your problem.

MediaElch Version:

  • 2.6.7-dev (nightly)
  • 2.6.6 stable

Operating System:

  • Windows
  • macOS
  • Linux (distribution: .)

Additional context
Add any other context about the problem here.
@meeotch
Copy link
Author

meeotch commented May 1, 2020 •
edited

Update: some things I tried:

  • deleting MediaElch's registry keys, and re-setting imdb as the source for actors
  • setting imdb as the source for all items on the TV Scraper tab
  • installing MediaElch on a new machine that never had an install before

Same results all around - tvdb is still being used for actor images. I verified the same behavior in v2.6.6 and v2.6.4. v2.6.2 will grab imdb actor images, but only the low-res versions.

Here's a debug log I grabbed from v2.6.7-dev, with all TV Scraper options set to imdb:

MediaElch 2020-05-01 14:37:29.430 INFO  : [TheTvDb] Search for: "russian doll"
MediaElch 2020-05-01 14:37:29.941 DEBUG : [TheTvDb] Received JSON web token
MediaElch 2020-05-01 14:37:30.280 DEBUG : Entered, size of results= 2
MediaElch 2020-05-01 14:37:32.489 DEBUG : Entered
MediaElch 2020-05-01 14:37:32.489 DEBUG : m_scraperId= "356640"
MediaElch 2020-05-01 14:37:32.495 DEBUG : Entered, message= "Please wait while your TV show is scraped" id= 1
MediaElch 2020-05-01 14:37:32.499 DEBUG : Entered, enabled= false
MediaElch 2020-05-01 14:37:32.499 DEBUG : Entered, m_scraperId "356640"
MediaElch 2020-05-01 14:37:32.499 INFO  : [TheTvDb] Load TV show with id: "356640"
MediaElch 2020-05-01 14:37:32.740 WARN  : [TheTvDb][ApiRequest] Network Error: "Error transferring https://api.thetvdb.com/series/356640/images/query?keyType=seasonwide - server replied: Not Found" for URL QUrl("https://api.thetvdb.com/series/356640/images/query?keyType=seasonwide")
MediaElch 2020-05-01 14:37:32.740 DEBUG : [TheTvDb] TV show with ID "356640" loaded
MediaElch 2020-05-01 14:37:32.742 DEBUG : [TheTvDb] Load IMDb TVShow with id: ImdbId("tt7520794")
MediaElch 2020-05-01 14:37:37.095 DEBUG : [NotificationBox] Hide Progress bar with id 1
MediaElch 2020-05-01 14:37:37.096 DEBUG : Entered, id= 1
MediaElch 2020-05-01 14:37:37.505 DEBUG : Entered
MediaElch 2020-05-01 14:37:37.505 DEBUG : Entered
MediaElch 2020-05-01 14:37:37.505 DEBUG : Entered
MediaElch 2020-05-01 14:37:37.545 DEBUG : Entered, enabled= false
MediaElch 2020-05-01 14:37:37.546 DEBUG : [DownloadManager] Enqueue download | QUrl("https://www.thetvdb.com/banners/posters/5c2ebbd543c63.jpg")
MediaElch 2020-05-01 14:37:37.546 DEBUG : [DownloadManager] Start next download
MediaElch 2020-05-01 14:37:37.546 DEBUG : Entered, enabled= false
MediaElch 2020-05-01 14:37:37.546 DEBUG : [DownloadManager] Enqueue download | QUrl("https://www.thetvdb.com/banners/fanart/original/5c374f6887c1e.jpg")
MediaElch 2020-05-01 14:37:37.546 DEBUG : Entered, enabled= false
MediaElch 2020-05-01 14:37:37.546 DEBUG : [DownloadManager] Enqueue download | QUrl("https://www.thetvdb.com/banners/graphical/5c371ae47837d.jpg")
MediaElch 2020-05-01 14:37:37.546 DEBUG : [DownloadManager] Enqueue download | QUrl("https://assets.fanart.tv/fanart/tv/356640/hdclearart/russian-doll-5c574d17ebfb5.png")
MediaElch 2020-05-01 14:37:37.546 DEBUG : [DownloadManager] Enqueue download | QUrl("https://assets.fanart.tv/fanart/tv/356640/hdtvlogo/russian-doll-5ce68e909bc91.png")
MediaElch 2020-05-01 14:37:37.546 DEBUG : [DownloadManager] Enqueue download | QUrl("https://assets.fanart.tv/fanart/tv/356640/characterart/russian-doll-5c574d250f92f.png")
MediaElch 2020-05-01 14:37:37.546 DEBUG : [DownloadManager] Enqueue download | QUrl("https://assets.fanart.tv/fanart/tv/356640/tvthumb/russian-doll-5c58146062f1b.jpg")
MediaElch 2020-05-01 14:37:37.546 DEBUG : [DownloadManager] Enqueue download | QUrl("https://assets.fanart.tv/fanart/tv/356640/seasonthumb/russian-doll-5ce68ed74ce1d.jpg")
MediaElch 2020-05-01 14:37:37.546 DEBUG : [DownloadManager] Enqueue download | QUrl("https://www.thetvdb.com/banners/actors/522895.jpg")
MediaElch 2020-05-01 14:37:37.546 DEBUG : [DownloadManager] Enqueue download | QUrl("https://www.thetvdb.com/banners/actors/523108.jpg")
MediaElch 2020-05-01 14:37:37.546 DEBUG : [DownloadManager] Enqueue download | QUrl("https://www.thetvdb.com/banners/actors/515156.jpg")
MediaElch 2020-05-01 14:37:37.546 DEBUG : [DownloadManager] Enqueue download | QUrl("https://www.thetvdb.com/banners/actors/523109.jpg")
MediaElch 2020-05-01 14:37:37.546 DEBUG : [DownloadManager] Enqueue download | QUrl("https://www.thetvdb.com/banners/actors/515158.jpg")
MediaElch 2020-05-01 14:37:37.546 DEBUG : [DownloadManager] Enqueue download | QUrl("https://www.thetvdb.com/banners/actors/515157.jpg")
MediaElch 2020-05-01 14:37:37.546 DEBUG : [DownloadManager] Enqueue download | QUrl("https://www.thetvdb.com/banners/actors/523110.jpg")
MediaElch 2020-05-01 14:37:37.546 DEBUG : [DownloadManager] Enqueue download | QUrl("https://www.thetvdb.com/banners/actors/523118.jpg")
MediaElch 2020-05-01 14:37:37.546 DEBUG : Entered, enabled= false
MediaElch 2020-05-01 14:37:37.546 DEBUG : [DownloadManager] Enqueue download | QUrl("https://www.thetvdb.com/banners/seasons/5c545d474ae03.jpg")
MediaElch 2020-05-01 14:37:37.546 DEBUG : Entered, msg= "Downloading images..." id= 40086
MediaElch 2020-05-01 14:37:37.546 DEBUG : Entered, message= "Downloading images..." id= 40086
MediaElch 2020-05-01 14:37:38.403 DEBUG : Cache dir DirectoryPath("C:/apps/MediaElch/images")
MediaElch 2020-05-01 14:37:38.404 DEBUG : [DownloadManager] Downloads left for show  "Russian Doll" : 16
MediaElch 2020-05-01 14:37:38.404 DEBUG : [DownloadManager] Start next download
MediaElch 2020-05-01 14:37:38.686 DEBUG : [DownloadManager] Downloads left for show  "Russian Doll" : 15
MediaElch 2020-05-01 14:37:38.686 DEBUG : [DownloadManager] Start next download

@bugwelle
Copy link
Collaborator

bugwelle commented May 2, 2020

Hi,

first of all: Thank you for the very detailed bug report. It's not often that I get such a well written issue :-)

To answer your questions:

I grabbed the latest nightly in order to get the "higher res imdb actors" fix, but the actor images displayed when I scrape are still from tvdb, despite the TV scraper->actors setting being set to imdb.

I should have been more precise in my changelog entry. Only the movie IMDb scraper has this change. I'm still working on a rewrite of MediaElch's TV scrapers in which I will (try to) improve the IMDb scraping for shows. Currently, the TheTvDb scraper loads all details from the IMDb website on its own. It does not use the movie IMDb scraper which gets better results and is also better tested.

Currently, only poster, fanart, and banner art shows up in the sidebar. Clicking on any other category fails with "server replied: bad gateway".

Could not reproduce this issue today. The error 502, a.k.a. "Bad Gateway" is a server-side error. This means it is an issue with the image provider, e.g. TheTvDb or fanart.tv. The error message could indeed be improved but I'm currently only printing the error message I get from Qt (our UI framework).

The new TV scraper interface is about 50% done. But it will definitely take another two weeks until it's finished.

@bugwelle bugwelle added component: TV shows TV shows, series, episodes component: scraper labels May 2, 2020
@meeotch
Copy link
Author

meeotch commented May 2, 2020

Thanks for the reply. And just to clarify: I'm seeing v2.6.2 grabbing low-res imdb images for TV shows, but all later versions are grabbing thetvdb images, regardless of settings.

The bad gateway thing seems to have resolved itself. I suspected, as you said, that it was a remote error.

@meeotch
Copy link
Author

meeotch commented May 2, 2020

Actually - I just tried scraping a movie with v2.6.7, and it's pulling the actor images from TheMovieDB instead of imdb, despite Custom Movie Scraper -> Actors being set to imdb.

Is there a setting somewhere else in the interface for actor images that I'm missing?

@bugwelle bugwelle mentioned this issue May 3, 2020
Merged
16 tasks
@bugwelle
Copy link
Collaborator

Is there a setting somewhere else in the interface for actor images that I'm missing?

No, not that I'm aware of. Sorry for the delay, it was a busy week. I didn't get to finish the pull request #972.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: scraper component: TV shows TV shows, series, episodes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meeotch @bugwelle