Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Td - 2179 ] Rich Message video template Feature #226

Conversation

Sathyan-Elangovan
Copy link
Contributor

@Sathyan-Elangovan Sathyan-Elangovan commented Sep 28, 2021

  1. Added the Rich Messages Video Template Feature.

We have two types of payloads to play videos in our sdk.

  1. Payload for web hosted videos
  2. Payload for Youtube videos

Below is the sample custom payload in our documentation.
Doucmentation link for Rich Video Template

{
  "platform": "kommunicate",
  "message": "Hello this is example videos",
  "metadata": {
    "contentType": "300",
    "templateId": "14",
    "payload": [
      {
        "url": "https://s3-migration-dot-applozic.appspot.com/rest/ws/aws/file/AM
Ifv95BPKLnhNtiYz0SNJYXTDhUkvhPYQikSjFaoL1hbg1zCcK8n6KZZfZC5Z42bfxOLaNeKSbKrt4o9pI0_ICb1fKKY8HqtcCeEuUZU8b18u8sr-4U5d4rFtmC79cn_0xaiV0MQfF01T0hAea8sQANoaYuvR5hQJHiFSB047yp1mkfqcwNb_ExaX1xutdJ8Qamkjp8xTKjlPiG0920T7qqLFIBxl1eGL7ikvTCtXG_f8Me8OKsEOhUXOP7LLuJLcOG_p8cijsp",
        "caption": "Video & Youtube Examples"
      },
      {
        "source": "youtube",
        "url": "https://www.youtube.com/embed/3-ijFzzF934"
      }
    ]
  }
}

Sample Images:

Sample Video:

WhatsApp.Video.2021-12-02.at.8.42.03.AM.mp4

@Sathyan-Elangovan Sathyan-Elangovan requested review from devashishmamgain and removed request for mukeshthawani October 8, 2021 03:10
app/build.gradle Outdated Show resolved Hide resolved
@devashishmamgain
Copy link
Contributor

@Sathyan-Elangovan what is the size of the new library?
How much SDK size will increase after this inclusion?

@Sathyan-Elangovan
Copy link
Contributor Author

@Sathyan-Elangovan what is the size of the new library?
How much SDK size will increase after this inclusion?

@devashishmamgain Downloadable size is increased by 2.7 MB

@devashishmamgain
Copy link
Contributor

@Sathyan-Elangovan what is the size of the new library?
How much SDK size will increase after this inclusion?

@devashishmamgain Downloadable size is increased by 2.7 MB

i guess that will be very high, we will need to look for alternate solution
@mukeshthawani @adarshmishra can you guys check what is the guideline for acceptable external library size?

@amntoppo
Copy link
Contributor

@Sathyan-Elangovan what is the size of the new library?
How much SDK size will increase after this inclusion?

@devashishmamgain Downloadable size is increased by 2.7 MB

ExoPlayer libraries modules can be added as dependency separately. You can have a look, if we are not using the whole library then we can add the modules separately. That should decrease the app size.

kommunicateui/build.gradle Outdated Show resolved Hide resolved
@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@Sathyan-Elangovan Sathyan-Elangovan dismissed devashishmamgain’s stale review December 7, 2021 10:29

Dev had reviewed due to the absence of Adarsh.I have done all the changes that dev requested & got approval from Adarsh.Dev mentioned that once Adarsh is back, he won't take part in reviewing PR. Considering that I am dismissing the review now.

@surajkukkipady18 surajkukkipady18 merged commit 309f4e8 into Kommunicate-io:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants