-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a one-step image/video upload flow #62
added a one-step image/video upload flow #62
Conversation
shubhamtewari
commented
Sep 22, 2019
•
edited
edited
- a new one step image/video upload flow has been added (open the image chooser, select multiple images/videos and click open), required files have been modified
- the MobicomAttachmentSelectorActivity has be modified to better seperate and UI and the controlling fucntions
- The file async task has been improved to be more generic and moved to a seperate file
- the KmAttachmnetsControllr has been created to seperate the code( refer to point 2) and the functions common between the new flow and the old flow
- comments have been added where ever i found difficulty in understanding in what the function did (only for the attachment upload parts)
.../main/java/com/applozic/mobicomkit/uiwidgets/conversation/activity/ConversationActivity.java
Show resolved
Hide resolved
.../main/java/com/applozic/mobicomkit/uiwidgets/conversation/activity/ConversationActivity.java
Outdated
Show resolved
Hide resolved
.../main/java/com/applozic/mobicomkit/uiwidgets/conversation/activity/ConversationActivity.java
Outdated
Show resolved
Hide resolved
.../main/java/com/applozic/mobicomkit/uiwidgets/conversation/activity/ConversationActivity.java
Outdated
Show resolved
Hide resolved
...m/applozic/mobicomkit/uiwidgets/conversation/activity/MobiComAttachmentSelectorActivity.java
Show resolved
Hide resolved
.../main/java/com/applozic/mobicomkit/uiwidgets/conversation/activity/ConversationActivity.java
Outdated
Show resolved
Hide resolved
...ava/com/applozic/mobicomkit/uiwidgets/conversation/fragment/MobiComConversationFragment.java
Outdated
Show resolved
Hide resolved
...ava/com/applozic/mobicomkit/uiwidgets/conversation/fragment/MobiComConversationFragment.java
Show resolved
Hide resolved
it means photo taken from camera |
then we can rename fromTakePhoto to fromCamera |
.../main/java/com/applozic/mobicomkit/uiwidgets/conversation/activity/ConversationActivity.java
Outdated
Show resolved
Hide resolved
.../main/java/com/applozic/mobicomkit/uiwidgets/conversation/activity/ConversationActivity.java
Show resolved
Hide resolved
.../main/java/com/applozic/mobicomkit/uiwidgets/conversation/activity/ConversationActivity.java
Show resolved
Hide resolved
...m/applozic/mobicomkit/uiwidgets/conversation/activity/MobiComAttachmentSelectorActivity.java
Outdated
Show resolved
Hide resolved
...m/applozic/mobicomkit/uiwidgets/conversation/activity/MobiComAttachmentSelectorActivity.java
Show resolved
Hide resolved
...ava/com/applozic/mobicomkit/uiwidgets/conversation/fragment/MobiComConversationFragment.java
Outdated
Show resolved
Hide resolved
...ava/com/applozic/mobicomkit/uiwidgets/conversation/fragment/MobiComConversationFragment.java
Outdated
Show resolved
Hide resolved
...ava/com/applozic/mobicomkit/uiwidgets/conversation/fragment/MobiComConversationFragment.java
Show resolved
Hide resolved
.../src/main/java/com/applozic/mobicomkit/uiwidgets/conversation/MultimediaOptionsGridView.java
Outdated
Show resolved
Hide resolved
...ava/com/applozic/mobicomkit/uiwidgets/conversation/fragment/MobiComConversationFragment.java
Outdated
Show resolved
Hide resolved
...ava/com/applozic/mobicomkit/uiwidgets/conversation/fragment/MobiComConversationFragment.java
Show resolved
Hide resolved
...eui/src/main/java/com/applozic/mobicomkit/uiwidgets/kommunicate/KmAttachmentsController.java
Outdated
Show resolved
Hide resolved
...eui/src/main/java/com/applozic/mobicomkit/uiwidgets/kommunicate/KmAttachmentsController.java
Outdated
Show resolved
Hide resolved
...eui/src/main/java/com/applozic/mobicomkit/uiwidgets/kommunicate/KmAttachmentsController.java
Outdated
Show resolved
Hide resolved
...eui/src/main/java/com/applozic/mobicomkit/uiwidgets/kommunicate/KmAttachmentsController.java
Show resolved
Hide resolved
...eui/src/main/java/com/applozic/mobicomkit/uiwidgets/kommunicate/KmAttachmentsController.java
Outdated
Show resolved
Hide resolved
...eui/src/main/java/com/applozic/mobicomkit/uiwidgets/kommunicate/KmAttachmentsController.java
Outdated
Show resolved
Hide resolved
*/ | ||
public interface PrePostUIMethods { | ||
void preTaskUIMethod(); | ||
void postTaskUIMethod(boolean b, File file); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shubhamtewari please use proper variable names and not a, b, c, d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still showing boolean b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be changed now
Sir regarding the fromCamera and fromMultiSelectActivity.
WHY can't they be set to true inside the methods themselves?
|