rich message factory pattern + rebase #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devashishmamgain
requested changes
Dec 26, 2019
...n/java/com/applozic/mobicomkit/uiwidgets/conversation/richmessaging/ButtonAlRichMessage.java
Outdated
Show resolved
Hide resolved
...main/java/com/applozic/mobicomkit/uiwidgets/conversation/richmessaging/FaqAlRichMessage.java
Outdated
Show resolved
Hide resolved
...main/java/com/applozic/mobicomkit/uiwidgets/conversation/richmessaging/FaqAlRichMessage.java
Outdated
Show resolved
Hide resolved
...ain/java/com/applozic/mobicomkit/uiwidgets/conversation/richmessaging/ListAlRichMessage.java
Outdated
Show resolved
Hide resolved
...om/applozic/mobicomkit/uiwidgets/conversation/richmessaging/adapters/ALBookingRMAdapter.java
Outdated
Show resolved
Hide resolved
...om/applozic/mobicomkit/uiwidgets/conversation/richmessaging/adapters/ALBookingRMAdapter.java
Outdated
Show resolved
Hide resolved
...om/applozic/mobicomkit/uiwidgets/conversation/richmessaging/adapters/ALBookingRMAdapter.java
Outdated
Show resolved
Hide resolved
...om/applozic/mobicomkit/uiwidgets/conversation/richmessaging/adapters/ALBookingRMAdapter.java
Outdated
Show resolved
Hide resolved
...om/applozic/mobicomkit/uiwidgets/conversation/richmessaging/adapters/ALBookingRMAdapter.java
Outdated
Show resolved
Hide resolved
...om/applozic/mobicomkit/uiwidgets/conversation/richmessaging/adapters/ALBookingRMAdapter.java
Outdated
Show resolved
Hide resolved
|
this issue and a few of my previous ones involves copying and pasting large amounts of old code. Sometimes the shortcoming of the previous code is overlooked. can a work around be suggested? |
this issue has already gotten to long |
devashishmamgain
approved these changes
Dec 29, 2019
.../java/com/applozic/mobicomkit/uiwidgets/conversation/richmessaging/AlRichMessageFactory.java
Outdated
Show resolved
Hide resolved
...n/java/com/applozic/mobicomkit/uiwidgets/conversation/richmessaging/ButtonAlRichMessage.java
Outdated
Show resolved
Hide resolved
...ain/java/com/applozic/mobicomkit/uiwidgets/conversation/richmessaging/ListAlRichMessage.java
Outdated
Show resolved
Hide resolved
...main/java/com/applozic/mobicomkit/uiwidgets/conversation/richmessaging/FaqAlRichMessage.java
Outdated
Show resolved
Hide resolved
...ain/java/com/applozic/mobicomkit/uiwidgets/conversation/richmessaging/ListAlRichMessage.java
Show resolved
Hide resolved
...om/applozic/mobicomkit/uiwidgets/conversation/richmessaging/adapters/ALBookingRMAdapter.java
Outdated
Show resolved
Hide resolved
...om/applozic/mobicomkit/uiwidgets/conversation/richmessaging/adapters/ALBookingRMAdapter.java
Outdated
Show resolved
Hide resolved
devashishmamgain
requested changes
Jan 1, 2020
...m/applozic/mobicomkit/uiwidgets/conversation/richmessaging/models/ALBookingDetailsModel.java
Show resolved
Hide resolved
.../java/com/applozic/mobicomkit/uiwidgets/conversation/richmessaging/AlRichMessageFactory.java
Show resolved
Hide resolved
devashishmamgain
requested changes
Jan 2, 2020
.../java/com/applozic/mobicomkit/uiwidgets/conversation/richmessaging/AlRichMessageFactory.java
Show resolved
Hide resolved
devashishmamgain
approved these changes
Jan 2, 2020
reytum
approved these changes
Jan 2, 2020
|
@shubhamtewari some conflict is coming, please check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the code has been checked only for the template ids: 3, 6, 7, 9, 10 i.e excluding 11 and faq. non-generic messages have not been checked.
Messages are rendered as required for payloads given in docs.