Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(repo): renaming kick-off #1903

Merged
merged 9 commits into from Jul 10, 2023
Merged

feat(repo): renaming kick-off #1903

merged 9 commits into from Jul 10, 2023

Conversation

tonymorony
Copy link

@tonymorony tonymorony commented Jul 10, 2023 •
edited

just initial renaming kick-off, please also propagate to master 馃檹

  • started to change naming
  • fixed CI badge
  • fixed twitter badge link

@tonymorony tonymorony requested a review from shamardy July 10, 2023 08:54
@tonymorony tonymorony marked this pull request as ready for review July 10, 2023 08:54
@onur-ozkan onur-ozkan added under review in progress Changes will be made from the author and removed under review labels Jul 10, 2023
@onur-ozkan
Copy link
Member

onur-ozkan commented Jul 10, 2023 •
edited

I think this is good start; but not ready to be merged yet. Still missing so many parts to be replaced with the new name/address(e.g. ref links in changelogs). Or should we do that part later ?

@tonymorony
Copy link
Author

tonymorony commented Jul 10, 2023 •
edited

I think this is good start; but not ready to be merged yet. Still missing so many parts to be replaced with the new name/address(e.g. ref links in changelogs). Or should we do that part later ?

right now the goal was mainly to align with todays PR announcement (repo rename / name in readme/logo), one more proper PR will be needed anyway (with changes in help output / possibly prints / adex-cli need different name and etc.)

as for changelog in particular - product called atomicdex-api at the time of relevant releases publishing and links to repo still working because of GH redirect so not sure if it worth changing

@onur-ozkan
Copy link
Member

right now the goal was mainly to align with todays PR announcement (repo rename / name in readme/logo), one more proper PR will be needed anyway (with changes in help output / possibly prints / adex-cli need different name and etc.)

Sounds good. Then we have just one problem which is build pipelines are broken. The logs doesn't look too clear, so I am not sure which part needs to be updated. It's worth trying to replace atomicDEX-API hardcoded paths under .github/workflows. If you don't have enough time on fixing this, you can leave the PR we can take care of finding/fixing the build issue.

@tonymorony tonymorony changed the title feat(repo): updated readme feat(repo): renaming kick-off Jul 10, 2023
onur-ozkan
onur-ozkan approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃敟

@onur-ozkan onur-ozkan added under review and removed in progress Changes will be made from the author labels Jul 10, 2023
@tonymorony tonymorony merged commit 6aa86a5 into dev Jul 10, 2023
28 of 32 checks passed
@shamardy shamardy deleted the rename branch July 10, 2023 14:59
@tonymorony tonymorony mentioned this pull request Jul 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onur-ozkan onur-ozkan onur-ozkan approved these changes

@shamardy shamardy Awaiting requested review from shamardy

Assignees
No one assigned
Labels
under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tonymorony @onur-ozkan