Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Protocol Integration]: BEP20 support #801

Closed
Milerius opened this issue Feb 1, 2021 · 11 comments
Closed

[Protocol Integration]: BEP20 support #801

Milerius opened this issue Feb 1, 2021 · 11 comments

Comments

@Milerius
Copy link

Milerius commented Feb 1, 2021

I propose to add the BEP20 smart chain binance protocol to be able to afford suitable and low costs in AtomicDEX

Benefits:

  • Low fees
  • Lot of pegged tokens such as XRP, ADA, DOT, BTC-BEP click here to see the list
  • Lot of pegged stable coins such as DAI, BUSD also with low fees
  • Binance gateway you can send BEP20 tokens directly to binance and then withdraw it from the real chain such as ETH

Requirements:

  • Requires BEP-2 support because fuel is paid in BNB

Documentation:

cc @cipig @ca333

@Cryptosaurus89
Copy link

Should have some priority as BSC is getting lots of attention..

@jvr-research
Copy link

I could really use something like this right now.

KMD deposit times are 1-2 hours on Binance which is very inconvenient at times and still has to go through BTC first. I would use this pairing almost on a daily basis.

@ptyx11
Copy link

ptyx11 commented Feb 27, 2021

let's get KMD also on BEP20

@jvr-research
Copy link

jvr-research commented Feb 27, 2021 via email

@phm87
Copy link

phm87 commented Feb 27, 2021

let's get KMD also on BEP20

I agree, it is a good idea, it was discussed today on discord but tokenize KMD on BSC is not related to AtomicDEX.

It seems that LTC and BCH are tokenized on BSC, I didn't find all details yet, here are some links I found.

https://www.binance.org/en/blog/anyswap-crosschain-dex-on-bsc/

How to join the BSC Cross-Chain Bridge

AnySwap Cross-Chain Bridge can dynamically add token support, and any ANY token holder (more than 1000 ANY token) can initiate a token cross-chain support proposal.

Initiate a proposal: https://vote.anyswap.exchange/#/anyswap/create

https://github.com/pancakeswap/pancake-swap-interface/blob/master/listing.md

https://lightrains.com/blogs/how-create-binance-token

  1. List your token
    Once the proposal is passed, you can them list your token. The fee of listing is 800 BNB.
    Article is from 2019 so I hope that the 800 BNB listing fee was lowered.

I hope that we'll be able to get KMD tokenized on BSC and create a BNB KMD Liquidity Pool. https://github.com/phm87/pancake-frontend/pull/1/files

@ca333
Copy link

ca333 commented Mar 14, 2021

@phm87
Copy link

phm87 commented Mar 14, 2021

https://bscscan.com/token/0x2003f7ba57ea956b05b85c60b4b2ceea9b111256 - BEP20 KMD Token

😍
https://bscscan.com/address/0x24b9b6c7b3b2c1a9c1f783228edf7d241091384a - PancakeSwap: KMD-BUSD
I hope that it will be added soon to the Main Staking Contract of PancakeSwap

@artemii235
Copy link
Member

artemii235 commented Mar 19, 2021

@artemii235
Copy link
Member

@Milerius You can now test it using the latest build from http://195.201.0.6/mm2.1-bsc/

Coins config for BNB and ADEX (test BEP20) testnet and mainnet:

	{
		"coin": "BNBT",
		"name": "binancesmartchaintest",
		"fname": "Ethereum",
		"avg_blocktime": 0.25,
		"rpcport": 80,
		"mm2": 1,
		"required_confirmations": 3,
		"protocol": {
			"type": "ETH"
		}
	},
    {
        "coin": "ADEXBSCT",
        "name": "adex_bsc_testnet",
        "fname": "adex",
        "rpcport": 80,
        "mm2": 1,
        "protocol": {
            "type": "ERC20",
            "protocol_data": {
                "platform": "BNBT",
                "contract_address": "0x464Ee03fBfC10f2FC8677Ee87d27bA3FD3aa4B09"
            }
        }
    },
    {
		"coin": "BNB",
		"name": "binancesmartchain",
		"fname": "Ethereum",
		"avg_blocktime": 0.25,
		"rpcport": 80,
		"mm2": 1,
		"required_confirmations": 3,
		"protocol": {
			"type": "ETH"
		}
	},
    {
        "coin": "ADEXBSC",
        "name": "adex_bsc",
        "fname": "adex",
        "rpcport": 80,
        "mm2": 1,
        "protocol": {
            "type": "ERC20",
            "protocol_data": {
                "platform": "BNB",
                "contract_address": "0x28E0685cc4C57a1CCF27090678A34Ebd6a641AC3"
            }
        }
    },

Enabling on testnet:

curl --url "http://127.0.0.1:7783" --data "{\"userpass\":\"$userpass\",\"method\":\"enable\",\"coin\":\"BNBT\",\"urls\":[\"https://data-seed-prebsc-1-s2.binance.org:8545\"],\"swap_contract_address\":\"0xcCD17C913aD7b772755Ad4F0BDFF7B34C6339150\"}"
curl --url "http://127.0.0.1:7783" --data "{\"userpass\":\"$userpass\",\"method\":\"enable\",\"coin\":\"ADEXBSCT\",\"urls\":[\"https://data-seed-prebsc-1-s2.binance.org:8545\"],\"swap_contract_address\":\"0xcCD17C913aD7b772755Ad4F0BDFF7B34C6339150\"}"

Enabling on mainnet:

curl --url "http://127.0.0.1:7783" --data "{\"userpass\":\"$userpass\",\"method\":\"enable\",\"coin\":\"BNB\",\"urls\":[\"https://bsc-dataseed.binance.org\"],\"swap_contract_address\":\"0xeDc5b89Fe1f0382F9E4316069971D90a0951DB31\"}"
curl --url "http://127.0.0.1:7783" --data "{\"userpass\":\"$userpass\",\"method\":\"enable\",\"coin\":\"ADEXBSC\",\"urls\":[\"https://bsc-dataseed.binance.org\"],\"swap_contract_address\":\"0xeDc5b89Fe1f0382F9E4316069971D90a0951DB31\"}"

@artemii235
Copy link
Member

@Milerius Please note that builds from http://195.201.0.6/mm2.1-bsc/ are not production ready and we also need this PR to be merged for proper fee ticker display: #861

artemii235 added a commit that referenced this issue Mar 23, 2021
* Temporary comment the usage of estimate_gas in get_fee_to_send_taker_fee.

* Update web3 and always use None block number in estimate_gas.

* Stop excluding mm2.1-bsc from CI.

* Fix CI pipeline.

* Fix CI pipeline.

* Stop always running Test MM2 on Linux to speed up the build.

* Fix max ETH withdraw.

* Put back the comment about possible estimate_gas failure.
@artemii235 artemii235 self-assigned this Mar 25, 2021
@Milerius
Copy link
Author

Implemented in #876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants