Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r2r] hotfix to disable spv in wasm #1479

Merged
merged 3 commits into from Sep 20, 2022
Merged

[r2r] hotfix to disable spv in wasm #1479

merged 3 commits into from Sep 20, 2022

Conversation

shamardy
Copy link
Collaborator

fixes #1471 by ignoring enable_spv_proof in wasm for now until an implementation for spv in wasm can be agreed upon #1471 (comment)

@shamardy shamardy changed the title [wip] hotfix to disable spv in wasm [r2r] hotfix to disable spv in wasm Sep 20, 2022
sergeyboyko0791
sergeyboyko0791 previously approved these changes Sep 20, 2022
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for this fix

@sergeyboyko0791
Copy link

I'll test it today

sergeyboyko0791
sergeyboyko0791 approved these changes Sep 20, 2022
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve. I've tested the changes manually in a browser. Everything works as expected.

@sergeyboyko0791 sergeyboyko0791 merged commit 2ec13a6 into dev Sep 20, 2022
@sergeyboyko0791 sergeyboyko0791 deleted the hotfix-disable-spv-wasm branch September 20, 2022 13:45
@shamardy shamardy mentioned this pull request Jan 16, 2023
Open
16 tasks
@shamardy shamardy mentioned this pull request Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyboyko0791 sergeyboyko0791 sergeyboyko0791 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shamardy @sergeyboyko0791