Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r2r] Add max_maker_vol RPC #1618

Merged
merged 7 commits into from Jan 20, 2023
Merged

[r2r] Add max_maker_vol RPC #1618

merged 7 commits into from Jan 20, 2023

Conversation

sergeyboyko0791
Copy link

  • Refactor get_max_vol by renaming and splitting into get_max_maker_vol and check_other_coin_balance_for_order_issue

@sergeyboyko0791
Add max_maker_vol RPC
d0b6b95 
* Refactor `get_max_vol` by renaming and splitting into `get_max_maker_vol` and `check_other_coin_balance_for_order_issue`
@sergeyboyko0791
Merge branch 'dev' into max-maker-vol-rpc
a9ad48e
@sergeyboyko0791 sergeyboyko0791 changed the title Add max_maker_vol RPC [r2r] Add max_maker_vol RPC Jan 18, 2023
@sergeyboyko0791 sergeyboyko0791 added this to Todo in MM 2.0 via automation Jan 18, 2023
@sergeyboyko0791 sergeyboyko0791 linked an issue Jan 18, 2023 that may be closed by this pull request
Add max_maker_vol RPC. #1604
Closed
@sergeyboyko0791 sergeyboyko0791 moved this from Todo to PR review in MM 2.0 Jan 18, 2023
shamardy
shamardy previously approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

artemii235
artemii235 requested changes Jan 19, 2023
View reviewed changes
Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have few notes about tests.

mm2src/mm2_main/tests/docker_tests/docker_tests_inner.rs Outdated Show resolved Hide resolved
mm2src/mm2_main/tests/docker_tests/docker_tests_inner.rs Outdated Show resolved Hide resolved
mm2src/mm2_main/tests/docker_tests/docker_tests_inner.rs Outdated Show resolved Hide resolved
mm2src/mm2_main/tests/docker_tests/docker_tests_inner.rs Outdated Show resolved Hide resolved
mm2src/mm2_main/tests/docker_tests/docker_tests_inner.rs Outdated Show resolved Hide resolved
@sergeyboyko0791
Fix PR issues
5976100 
* Refactor `test_get_max_maker_vol` and `test_get_max_maker_vol_error` tests
* Add `mm2_test_helpers::max_maker_vol`
artemii235
artemii235 requested changes Jan 20, 2023
View reviewed changes
Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixes! One more note.

mm2src/mm2_main/src/lp_swap/max_maker_vol_rpc.rs Outdated Show resolved Hide resolved
artemii235
artemii235 approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@artemii235 artemii235 merged commit 7201146 into dev Jan 20, 2023
MM 2.0 automation moved this from PR review to Done Jan 20, 2023
@artemii235 artemii235 deleted the max-maker-vol-rpc branch January 20, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemii235 artemii235 artemii235 approved these changes

@shamardy shamardy shamardy left review comments

Assignees
No one assigned
Labels
None yet
Projects
MM 2.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add max_maker_vol RPC.
3 participants
@sergeyboyko0791 @artemii235 @shamardy