Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r2r] Implement block headers storage for IndexedDB and re-enable spv in wasm #1644

Merged
merged 22 commits into from Feb 20, 2023
Merged

[r2r] Implement block headers storage for IndexedDB and re-enable spv in wasm #1644

merged 22 commits into from Feb 20, 2023

Conversation

borngraced
Copy link
Member

completes task 4 in #1612

@borngraced
start indexddb block header storage impl
cb854a1 
Signed-off-by: borngraced <samiodev@icloud.com>
@borngraced
save dev state
4036637 
Signed-off-by: borngraced <samiodev@icloud.com>
@borngraced
impl IDBBlockHeadersStorage and fix clippy
902b30a 
Signed-off-by: borngraced <samiodev@icloud.com>
@borngraced
impl add_block_headers_to_storage and unit test.
d242073 
Signed-off-by: borngraced <samiodev@icloud.com>
@borngraced
impl indexeddb get_block_header and unit test.
81e3a65 
Signed-off-by: borngraced <samiodev@icloud.com>
@borngraced
saved ev state
88ac5b8 
Signed-off-by: borngraced <samiodev@icloud.com>
@borngraced
impl get_block_height_by_hash and unit test
c920936 
Signed-off-by: borngraced <samiodev@icloud.com>
@borngraced
impl get_block_header_raw and unit test
b46acba 
Signed-off-by: borngraced <samiodev@icloud.com>
@borngraced
impl get_last_block_height and unit test for indexed db
207c6ae 
Signed-off-by: borngraced <samiodev@icloud.com>
@borngraced
fix test_get_last_block_height
112d51d 
Signed-off-by: borngraced <samiodev@icloud.com>
@borngraced
impl get_last_block_header_with_non_max_bits and unit test
576c7a8 
Signed-off-by: borngraced <samiodev@icloud.com>
@borngraced
fmt imports
2ed19ab 
Signed-off-by: borngraced <samiodev@icloud.com>
@borngraced borngraced self-assigned this Feb 3, 2023
@borngraced
re-enable spv for wasm.
3d2f7a8 
Signed-off-by: borngraced <samiodev@icloud.com>
@borngraced borngraced changed the title [wip] Implement block headers storage for IndexedDB and re-enable spv in wasm [r2r] Implement block headers storage for IndexedDB and re-enable spv in wasm Feb 3, 2023
@borngraced
use multi_index for querying and inserting block_header
44b48bd 
Signed-off-by: borngraced <samiodev@icloud.com>
@borngraced
use multi_index for querying block_header hash
6516c23 
Signed-off-by: borngraced <samiodev@icloud.com>
@borngraced
fix wasm imports and index
9f10375 
Signed-off-by: borngraced <samiodev@icloud.com>
sergeyboyko0791
sergeyboyko0791 suggested changes Feb 7, 2023
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!
In general, everything looks great, we only need to change a few small details.

mm2src/coins/tx_history_storage/tx_history_v2_tests.rs Outdated Show resolved Hide resolved
mm2src/coins/tx_history_storage/tx_history_v2_tests.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_block_header_storage/wasm/block_header_table.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_block_header_storage/wasm/indexeddb_block_header_storage.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_block_header_storage/wasm/indexeddb_block_header_storage.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_block_header_storage/wasm/indexeddb_block_header_storage.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_block_header_storage/wasm/indexeddb_block_header_storage.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_block_header_storage/wasm/indexeddb_block_header_storage.rs Outdated Show resolved Hide resolved
mm2src/mm2_bitcoin/spv_validation/src/storage.rs Outdated Show resolved Hide resolved
mm2src/mm2_bitcoin/spv_validation/src/storage.rs Outdated Show resolved Hide resolved
@borngraced borngraced changed the title [r2r] Implement block headers storage for IndexedDB and re-enable spv in wasm [wip] Implement block headers storage for IndexedDB and re-enable spv in wasm Feb 7, 2023
@borngraced
fix review notes
438d8e1 
Signed-off-by: borngraced <samiodev@icloud.com>
@borngraced
refactor sql storage and indexeddb tests
69aaae4 
Signed-off-by: borngraced <samiodev@icloud.com>
@borngraced
Copy link
Member Author

this is ready for another round of review @sergeyboyko0791

@borngraced borngraced changed the title [wip] Implement block headers storage for IndexedDB and re-enable spv in wasm [r2r] Implement block headers storage for IndexedDB and re-enable spv in wasm Feb 8, 2023
@shamardy shamardy mentioned this pull request Feb 10, 2023
Open
@shamardy shamardy added this to Todo in MM 2.0 via automation Feb 13, 2023
@shamardy shamardy moved this from Todo to PR review in MM 2.0 Feb 13, 2023
sergeyboyko0791
sergeyboyko0791 suggested changes Feb 13, 2023
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes! Just a few minor changes please (mostly related to the unit tests) :)

mm2src/coins/utxo/utxo_block_header_storage/mod.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_block_header_storage/mod.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_block_header_storage/mod.rs Outdated Show resolved Hide resolved
@borngraced
Merge branch 'dev' into spv-indexdb-impl
4339ef8 
# Conflicts:
#	mm2src/coins/utxo/utxo_block_header_storage/indexedb_block_header_storage.rs
#	mm2src/coins/utxo/utxo_block_header_storage/sql_block_header_storage.rs
#	mm2src/coins/utxo/utxo_builder/utxo_coin_builder.rs
#	mm2src/coins/utxo/utxo_builder/utxo_conf_builder.rs
#	mm2src/coins/utxo/utxo_tests.rs
@borngraced
saved dev state after merge
40f2885 
Signed-off-by: borngraced <samiodev@icloud.com>
@borngraced
fix failing unit tests
ba34d17 
Signed-off-by: borngraced <samiodev@icloud.com>
@borngraced
fix review notes
ac42386 
Signed-off-by: borngraced <samiodev@icloud.com>
sergeyboyko0791
sergeyboyko0791 approved these changes Feb 14, 2023
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes! Just one minor suggestion

mm2src/mm2_bitcoin/spv_validation/src/storage.rs Show resolved Hide resolved
@borngraced borngraced mentioned this pull request Feb 17, 2023
Merged
shamardy
shamardy approved these changes Feb 20, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work 🔥 !

@shamardy shamardy merged commit d01dd41 into dev Feb 20, 2023
MM 2.0 automation moved this from PR review to Done Feb 20, 2023
@shamardy shamardy deleted the spv-indexdb-impl branch February 20, 2023 14:56
@borngraced borngraced mentioned this pull request Feb 20, 2023
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamardy shamardy shamardy approved these changes

@sergeyboyko0791 sergeyboyko0791 sergeyboyko0791 approved these changes

Assignees

@borngraced borngraced

Labels
None yet
Projects
MM 2.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@borngraced @shamardy @sergeyboyko0791