Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r2r] Hardware Wallet enhancements #1672

Merged
merged 13 commits into from Feb 25, 2023
Merged

[r2r] Hardware Wallet enhancements #1672

merged 13 commits into from Feb 25, 2023

Conversation

sergei-boiko
Copy link

@sergeyboyko0791
Use a Shared DB in WASM for HD account storage
6f8d35c 
* Add `MmCtx::shared_db_id`
* Add `get_shared_db_id` RPC
@sergeyboyko0791
Merge branch 'dev' into shared-db
872a138
@sergeyboyko0791
Use a Shared DB for HD account sqlite storage
59e5c78 
* Add `MmCtx::shared_sqlite_conn`
* Remove `mm2_rmd160` property from HD wallet storage
* Refactor SQL queries by using named params
@sergeyboyko0791
Add HDWalletCoinOps::generate_and_confirm_new_address
173f8e3
@sergeyboyko0791
Add task::get_new_address::* RPCs
6b4ec0f 
* TODO implement `task::get_new_address::cancel`
* Add `MockableConfirmAddress` for tests
@sergeyboyko0791
Minor changes
a3706d7
@sergeyboyko0791
Minor fixes and changes
66c43bb
@sergeyboyko0791
Refactor Trezor so it cannot be used after being disconnected
d28c11f 
* Add `trezor_connection_status` RPC
* `HwCtx::trezor` should return `TrezorSession<'a>`
@sergeyboyko0791
Fix PR issues
3a2fd3d 
* Fix comments
* Use `EnumFromInner`, `EnumFromStringify` derive macros
@sergeyboyko0791
Fix PR issues
12e7bee 
* Rename `NullStringPassphrase` to `EmptyPassphrase`
@sergeyboyko0791
Ignore cargo deny issues for a while
bb0da39
@sergeyboyko0791
Merge branch 'dev' into shared-db
81e1ea4
@sergeyboyko0791
Fix PR issues
99954a7 
* Incorrect behaviour if Passphrase is enabled
* Don't create new session on each device interaction
* Fix merge conflicts
@sergei-boiko
Copy link
Author

@anarkiVan please check if this PR fixes the issue you met

When the trezor security's option passphrase is enabled and i try to withdraw coin from WebDEX i got an error:
Internal error: Unexpected interaction request: PassphraseRequest
Also on each asset activation it asks to enter seed
ps: During connection to trezor i skip sending passphrase and our old logic just send empty string

@sergei-boiko sergei-boiko mentioned this pull request Feb 21, 2023
Closed
@anarkiVan
Copy link

@anarkiVan please check if this PR fixes the issue you met

When the trezor security's option passphrase is enabled and i try to withdraw coin from WebDEX i got an error:
Internal error: Unexpected interaction request: PassphraseRequest
Also on each asset activation it asks to enter seed
ps: During connection to trezor i skip sending passphrase and our old logic just send empty string

@sergei-boiko It looks like my issues have solved here

@sergei-boiko
Copy link
Author

@anarkiVan great, thank you for the testing!
@shamardy the PR is ready for the review

shamardy
shamardy approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes!

@ca333 ca333 requested a review from DeckerSU February 24, 2023 08:02
@ca333 ca333 merged commit 5549d69 into KomodoPlatform:dev Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ca333 ca333 ca333 approved these changes

@shamardy shamardy shamardy approved these changes

@DeckerSU DeckerSU Awaiting requested review from DeckerSU

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sergei-boiko @anarkiVan @ca333 @shamardy @sergeyboyko0791