[r2r] Complete MetaMask #1674

sergei-boiko · 2023-02-22T22:19:44Z

Done:

Check if corresponding ETH chain is known by MetaMask wallet on coin activation using wallet_switchEthereumChain
Figure out how to refactor ETH/ERC20 withdraw taking into account that the only way to sign a transaction is to send it using eth_sendTransaction.
Extract address's public key using eth_singTypedDataV4 as Artem suggested Add possibility to login with metamask-like browser wallets #1167 (comment).
Update rust-web3 crate.
Perform swaps with coins activated with MetaMask.

TODO:

Figure out how to mock the MetaMask provider to test the swaps and the wallet functionality.
Design a notification protocol to notify the GUI on ETH account changed.
Find a workaround to sign/send Swap Watcher P2P messages

* Match MetaMask RPC error * Add and use `wallet_switch_ethereum_chain` RPC

* TODO error deserializing a nonce

* Fix `ethabi::Function::decode_input`

# Conflicts: # mm2src/coins/eth.rs # mm2src/coins/eth/web3_transport/metamask_transport.rs

* Wrap the `web3::Eip1193` transport into an event-driven pattern to make it `Send` * Fix circle dependencies by removing `serde_json::preserve_order` feature * Avoid using `serde_json::RawValue` for the `MmNumber`

* TODO figure out how to integrate `MetamaskSession` into `EthCoin`

* Add `MetamaskError` to all mm2 RPC errors * Get rid of `Web3Session` that makes the code super complicated

* Add `mm2_eth` crate with EIP712 helpers * Don't check ETH account on each RPC * Don't return a public key on `task::connect_metamask::init`

* Try to switch the ChainId on each RPC * Check if `WithdrawRequest::broadcast` is set

* Remove `url` and `version` fields from `AtomicDEXDomain` type

* Reimplement `ParityNonce` and `EthNonce` custom namespaces from `artemii235/rust-web3`

…_fee`

* Use `serde-json::preserve_order`, `serde-json::raw_value` features * Use a custom `rust-web3` crate

# Conflicts: # mm2src/coins/eth.rs

* Check the function's signature on `decode_contract_call`

* Split `sign_and_send_transaction_impl` into with a keypair and metamask

* Rename `EthConfig` to `MetamaskEthConfig` * Make `pub(crate)` most of the ETH related structures * Specify the `rust-web3` tag

* Uninline extra `SwapOps` methods * Return a Lightning Node ID as an HTLC pubkey

sergei-boiko · 2023-02-22T22:21:55Z

Fixes #1591 merge conflicts.

shamardy

Previously approved here #1591

ca333 · 2023-02-25T10:22:03Z

will propagate this to dev so we can run the secure code review / dependency update analysis from there @DeckerSU

ca333

missing dependency update review

sergeyboyko0791 added 30 commits December 6, 2022 15:27

Save dev state

c87e84c

Check if corresponding ETH chain is known by MetaMask

f50a884

* Match MetaMask RPC error * Add and use `wallet_switch_ethereum_chain` RPC

Save withdraw dev state

b087c05

* TODO error deserializing a nonce

Fix compilation bugs after web3 update

476e53c

* Fix `ethabi::Function::decode_input`

Merge branch 'upgrade-web3' into metamask-feature

887a88f

# Conflicts: # mm2src/coins/eth.rs # mm2src/coins/eth/web3_transport/metamask_transport.rs

Fix nonce request by updating web3

ec817b2

Integrate web3::Eip1193 transport

d21695e

* Wrap the `web3::Eip1193` transport into an event-driven pattern to make it `Send` * Fix circle dependencies by removing `serde_json::preserve_order` feature * Avoid using `serde_json::RawValue` for the `MmNumber`

Refactor mm2_metamask by using web3::Eip1193

7bd0426

* TODO figure out how to integrate `MetamaskSession` into `EthCoin`

Lock MetamaskSession and switch ChainId if required on each RPC

99c43be

* Add `MetamaskError` to all mm2 RPC errors * Get rid of `Web3Session` that makes the code super complicated

Check if the MetMask account is still the same on each RPC

51390ff

Merge branch 'dev' into metamask-feature

9b66f09

Request to sign a Login request and extract pubkey

738b5cb

* Add `mm2_eth` crate with EIP712 helpers * Don't check ETH account on each RPC * Don't return a public key on `task::connect_metamask::init`

Add SwapOps::derive_htlc_pubkey

2937c56

Make sign_and_send_transaction_impl compatible with MetaMask wallet

d12ba9c

Read 'rpc_chain_id' param if chain_id is not set

881391c

* Try to switch the ChainId on each RPC * Check if `WithdrawRequest::broadcast` is set

Take project on task::connect_metamask::init request

5bec977

* Remove `url` and `version` fields from `AtomicDEXDomain` type

Minor changes

c2b43eb

Merge branch 'dev' into metamask-feature

02d730c

Push missing files

308a9aa

Import upstream rust-web3 crate

7210a5f

* Reimplement `ParityNonce` and `EthNonce` custom namespaces from `artemii235/rust-web3`

Import artemii235's parity-ethereum crate

4056ee7

Fix tests

5ae56fd

Fix udeps

d2b86bd

Fix mm2_number tests

17eddf2

Fix test_wait_for_payment_spend_timeout

5f4ceb9

Fix get_erc20_sender_trade_preimage and `test_get_fee_to_send_taker…

90648a9

…_fee`

Minor changes

e08b41b

Fix mm_number deserializing by rolling the changes back

ff358f7

* Use `serde-json::preserve_order`, `serde-json::raw_value` features * Use a custom `rust-web3` crate

Use KomodoPlatform::rust-web3

fb0c6bd

Remove MetamaskError from a common-purpose error enums

44c63f7

sergeyboyko0791 added 19 commits January 5, 2023 13:15

Merge branch 'dev' into metamask-feature

d374762

# Conflicts: # mm2src/coins/eth.rs

Don't request ETH nonce if the transport is MetaMask

e99ff6b

* Check the function's signature on `decode_contract_call`

Rename WithdrawError::MetamaskBroadcastExpected to BroadcastExpected

954565b

Test mm2_eth::recover_pubkey

a14add5

Test mm2_eth::address_from_pubkey_uncompressed

1b48f2e

Fix test_tendermint_tx_history

69d71af

Refactor EthCoin::sign_and_send_transaction

8678d8a

* Split `sign_and_send_transaction_impl` into with a keypair and metamask

Fix PR issues

31f4275

* Rename `EthConfig` to `MetamaskEthConfig` * Make `pub(crate)` most of the ETH related structures * Specify the `rust-web3` tag

Minor changes

a85eb6c

* Uninline extra `SwapOps` methods * Return a Lightning Node ID as an HTLC pubkey

Merge branch 'dev' into metamask-feature

104fd0a

Minor changes

b4b85b8

Implement SafeTypeCastingNumbers for U256

f5c6325

Minor fix

e048546

Add a few more comments

1029c08

Consider web3::Error::Unreachable as a Transport error

c4706b5

Merge branch 'dev' into metamask-feature

f8689d3

Merge branch 'dev' into metamask-feature

0b6a4ff

Merge branch 'dev' into metamask-feature

4f7d961

Merge branch 'dev' into metamask-feature

daee127

ca333 mentioned this pull request Feb 23, 2023

[r2r] Complete MetaMask #1591

Closed

8 tasks

shamardy approved these changes Feb 23, 2023

View reviewed changes

ca333 requested review from DeckerSU and ca333 February 24, 2023 08:02

ca333 approved these changes Feb 25, 2023

View reviewed changes

ca333 merged commit f32cb17 into KomodoPlatform:dev Feb 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[r2r] Complete MetaMask #1674

[r2r] Complete MetaMask #1674

sergei-boiko commented Feb 22, 2023 •

edited

sergei-boiko commented Feb 22, 2023

shamardy left a comment

ca333 commented Feb 25, 2023

ca333 left a comment

[r2r] Complete MetaMask #1674

[r2r] Complete MetaMask #1674

Conversation

sergei-boiko commented Feb 22, 2023 • edited

sergei-boiko commented Feb 22, 2023

shamardy left a comment

Choose a reason for hiding this comment

ca333 commented Feb 25, 2023

ca333 left a comment

Choose a reason for hiding this comment

sergei-boiko commented Feb 22, 2023 •

edited