Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r2r] IndexedDB Cursor Iterator #1678

Merged
merged 7 commits into from Mar 7, 2023
Merged

[r2r] IndexedDB Cursor Iterator #1678

merged 7 commits into from Mar 7, 2023

Conversation

sergeyboyko0791
Copy link

@sergeyboyko0791 sergeyboyko0791 commented Feb 24, 2023 •
edited

Fixes #1643

  • Refactor IndexedDB Cursor so it can be used to iterate over the items step-by-step.
  • Fix and optimize IDBBlockHeadersStorage

@sergeyboyko0791
Save dev state
fbcfe46
@sergeyboyko0791
Refactor IndexedDB Cursor
c7792c2 
* Add `CursorIter::next`
* Add `IdbEmptyCursor`
@sergeyboyko0791
Merge branch 'dev' into cursor-iter
bded40c
@sergeyboyko0791
Fix merge conflicts
b4acf2c
@sergeyboyko0791
Fix and optimize IndexedDbBlockHeaderStorage
4deacf5 
* Make `height: BeBigUint` instead of `u64`
* Fix `BlockHeaderStorageTable::TICKER_HEIGHT_INDEX` index
@sergeyboyko0791
Fix TODOs
3b4a6e0
borngraced
borngraced previously approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@borngraced borngraced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work and very clear to me! thanks

shamardy
shamardy previously approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great enhancement! Only non-blockers

mm2src/coins/utxo/utxo_block_header_storage/wasm/indexeddb_block_header_storage.rs Show resolved Hide resolved
mm2src/coins/utxo/utxo_block_header_storage/wasm/indexeddb_block_header_storage.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/utxo_block_header_storage/wasm/indexeddb_block_header_storage.rs Outdated Show resolved Hide resolved
@sergeyboyko0791 sergeyboyko0791 dismissed stale reviews from shamardy and borngraced via d8bc96c March 2, 2023 11:15
shamardy
shamardy approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve

@shamardy shamardy merged commit 211492e into KomodoPlatform:dev Mar 7, 2023
@borngraced borngraced mentioned this pull request Mar 7, 2023
Closed
@ca333 ca333 mentioned this pull request Mar 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borngraced borngraced borngraced left review comments

@shamardy shamardy shamardy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sergeyboyko0791 @shamardy @borngraced