Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand OperationFailure::Other error #1719

Merged
merged 13 commits into from Mar 20, 2023
Merged

Expand OperationFailure::Other error #1719

merged 13 commits into from Mar 20, 2023

Conversation

laruh
Copy link
Member

@laruh laruh commented Mar 15, 2023

related to #1687

OperationFailure::Other error was expanded, new errors were matched with HwRpcError (will have HwError type instead of InternalError).

@laruh laruh requested a review from shamardy March 15, 2023 15:32
@laruh
Copy link
Member Author

laruh commented Mar 16, 2023

@yurii-khi Hi! its ready for testing.

@yurii-khi
Copy link

@yurii-khi Hi! its ready for testing.

Works fine on my side, thanks @laruh !

@laruh laruh changed the title [r2r] Expand OperationFailure::Other error Expand OperationFailure::Other error Mar 16, 2023
@laruh laruh added this to Todo in MM 2.0 via automation Mar 16, 2023
@laruh laruh moved this from Todo to PR review in MM 2.0 Mar 16, 2023
shamardy
shamardy previously approved these changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix! One non-blocker.

mm2src/trezor/src/client.rs Show resolved Hide resolved
shamardy
shamardy approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve

@shamardy shamardy merged commit 789e75d into dev Mar 20, 2023
MM 2.0 automation moved this from PR review to Done Mar 20, 2023
@shamardy shamardy deleted the improve_trezor_withdraw_error branch March 20, 2023 14:25
@ca333 ca333 mentioned this pull request Mar 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamardy shamardy shamardy approved these changes

Assignees
No one assigned
Labels
under review
Projects
MM 2.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@laruh @yurii-khi @shamardy