Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep active on restart #1632

Merged
merged 24 commits into from Dec 10, 2022
Merged

Keep active on restart #1632

merged 24 commits into from Dec 10, 2022

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Feb 24, 2022 •
edited

When resetting assets, this will preserve active coins.
Closes #1544 and #1632

@smk762 smk762 requested review from Milerius, a user and tonymorony February 24, 2022 18:06
Milerius
Milerius suggested changes Feb 24, 2022
View reviewed changes
src/core/atomicdex/pages/qt.settings.page.cpp Outdated Show resolved Hide resolved
src/core/atomicdex/pages/qt.settings.page.cpp Outdated Show resolved Hide resolved
@smk762 smk762 requested a review from Milerius February 24, 2022 19:35
@smk762 smk762 requested a review from Milerius February 24, 2022 19:53
ghost
ghost suggested changes Mar 1, 2022
View reviewed changes
src/core/atomicdex/pages/qt.settings.page.cpp Outdated Show resolved Hide resolved
src/core/atomicdex/pages/qt.settings.page.cpp Outdated Show resolved Hide resolved
@smk762 smk762 requested a review from a user March 2, 2022 02:02
ghost
ghost previously approved these changes Mar 2, 2022
View reviewed changes
@tonymorony
Copy link
Contributor

on OSX app doesn't restart automatically for me after reset (didn't test on other OS yet)

coins list remain the same after restart, so this part works fine

relevant log:

[17:01:24] [info] [app.cpp:801] [2702049]: restarting the application
[17:01:24] [error] [app.cpp:815] [2702049]: Couldn't start a new process
[17:01:24] [debug] [app.cpp:651] [2702049]: will quit app, prevent all threading event
[17:01:24] [info] [mm2.service.cpp:295] [2702049]: destroying mm2 service...
[17:01:24] [info] [mm2.service.cpp:299] [2702049]: mm2 signals successfully disconnected
[17:01:24] [info] [mm2.service.cpp:307] [2702049]: processing mm2 stop batch request
[17:01:24] [info] [mm2.service.cpp:303] [2702049]: preparing mm2 stop batch request
[17:01:24] [info] [mm2.service.cpp:310] [2702049]: mm2 stop batch answer received
[17:01:24] [info] [mm2.service.cpp:315] [2702049]: mm2 successfully stopped with rpc stop
[17:01:24] [info] [mm2.service.cpp:346] [2702049]: mm2 init thread destroyed
[17:01:24] [info] [mm2.service.cpp:348] [2702049]: mm2 service fully destroyed
[17:01:24] [info] [main.prerequisites.hpp:216] [2702049]: wally successfully cleaned
[17:01:24] [debug] [main.prerequisites.hpp:86] [2702049]: FatalErrorModal Destructed
[17:01:24] [debug] [main.prerequisites.hpp:86] [2702049]: FatalErrorModal Destructed
[17:01:24] [info] [qt.orders.widget.cpp:35] [2702049]: qt_orders widget destroyed
[17:01:24] [info] [coingecko.wallet.charts.cpp:44] [2702049]: coingecko_wallet_charts_service destroyed

tonymorony
tonymorony suggested changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@tonymorony tonymorony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^

@ghost
Copy link

ghost commented Mar 2, 2022

on OSX app doesn't restart automatically for me after reset (didn't test on other OS yet)

coins list remain the same after restart, so this part works fine

relevant log:

[17:01:24] [info] [app.cpp:801] [2702049]: restarting the application
[17:01:24] [error] [app.cpp:815] [2702049]: Couldn't start a new process
[17:01:24] [debug] [app.cpp:651] [2702049]: will quit app, prevent all threading event
[17:01:24] [info] [mm2.service.cpp:295] [2702049]: destroying mm2 service...
[17:01:24] [info] [mm2.service.cpp:299] [2702049]: mm2 signals successfully disconnected
[17:01:24] [info] [mm2.service.cpp:307] [2702049]: processing mm2 stop batch request
[17:01:24] [info] [mm2.service.cpp:303] [2702049]: preparing mm2 stop batch request
[17:01:24] [info] [mm2.service.cpp:310] [2702049]: mm2 stop batch answer received
[17:01:24] [info] [mm2.service.cpp:315] [2702049]: mm2 successfully stopped with rpc stop
[17:01:24] [info] [mm2.service.cpp:346] [2702049]: mm2 init thread destroyed
[17:01:24] [info] [mm2.service.cpp:348] [2702049]: mm2 service fully destroyed
[17:01:24] [info] [main.prerequisites.hpp:216] [2702049]: wally successfully cleaned
[17:01:24] [debug] [main.prerequisites.hpp:86] [2702049]: FatalErrorModal Destructed
[17:01:24] [debug] [main.prerequisites.hpp:86] [2702049]: FatalErrorModal Destructed
[17:01:24] [info] [qt.orders.widget.cpp:35] [2702049]: qt_orders widget destroyed
[17:01:24] [info] [coingecko.wallet.charts.cpp:44] [2702049]: coingecko_wallet_charts_service destroyed

Are you sure it does not happen also on dev ? Because this PR does not modify the app starting logic

@smk762
Copy link
Collaborator Author

smk762 commented Mar 2, 2022

Seems to be working ok here on mac mini. maybe we need more delay time between shut down and restart on faster systems?

@tonymorony
Copy link
Contributor

Are you sure it does not happen also on dev ? Because this PR does not modify the app starting logic

just rechecked - restarting automagically for me on latest dev

Seems to be working ok here on mac mini. maybe we need more delay time between shut down and restart on faster systems?

I'm on M1 Max, maybe it makes the difference

@tonymorony tonymorony added 0.5.6 and removed 0.5.5 labels Mar 7, 2022
@smk762 smk762 mentioned this pull request May 17, 2022
Merged
@smk762 smk762 mentioned this pull request May 17, 2022
Closed
@smk762 smk762 mentioned this pull request Sep 13, 2022
Merged
2 tasks
SirSevenG
SirSevenG previously approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@SirSevenG SirSevenG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@tonymorony tonymorony marked this pull request as draft October 10, 2022 12:09
@smk762 smk762 added 0.5.8 and removed next iteration to not forget to include it labels Nov 18, 2022
@smk762 smk762 mentioned this pull request Nov 30, 2022
Open
@smk762 smk762 self-assigned this Dec 2, 2022
@smk762 smk762 requested review from Milerius, SirSevenG and Canialon and removed request for Milerius December 6, 2022 08:16
@smk762 smk762 marked this pull request as ready for review December 6, 2022 08:16
@smk762
Copy link
Collaborator Author

smk762 commented Dec 6, 2022

on OSX app doesn't restart automatically for me after reset (didn't test on other OS yet)

coins list remain the same after restart, so this part works fine

relevant log:

[17:01:24] [info] [app.cpp:801] [2702049]: restarting the application
[17:01:24] [error] [app.cpp:815] [2702049]: Couldn't start a new process
[17:01:24] [debug] [app.cpp:651] [2702049]: will quit app, prevent all threading event
[17:01:24] [info] [mm2.service.cpp:295] [2702049]: destroying mm2 service...
[17:01:24] [info] [mm2.service.cpp:299] [2702049]: mm2 signals successfully disconnected
[17:01:24] [info] [mm2.service.cpp:307] [2702049]: processing mm2 stop batch request
[17:01:24] [info] [mm2.service.cpp:303] [2702049]: preparing mm2 stop batch request
[17:01:24] [info] [mm2.service.cpp:310] [2702049]: mm2 stop batch answer received
[17:01:24] [info] [mm2.service.cpp:315] [2702049]: mm2 successfully stopped with rpc stop
[17:01:24] [info] [mm2.service.cpp:346] [2702049]: mm2 init thread destroyed
[17:01:24] [info] [mm2.service.cpp:348] [2702049]: mm2 service fully destroyed
[17:01:24] [info] [main.prerequisites.hpp:216] [2702049]: wally successfully cleaned
[17:01:24] [debug] [main.prerequisites.hpp:86] [2702049]: FatalErrorModal Destructed
[17:01:24] [debug] [main.prerequisites.hpp:86] [2702049]: FatalErrorModal Destructed
[17:01:24] [info] [qt.orders.widget.cpp:35] [2702049]: qt_orders widget destroyed
[17:01:24] [info] [coingecko.wallet.charts.cpp:44] [2702049]: coingecko_wallet_charts_service destroyed

Can you please check if this still happens for you @tonymorony ?

SirSevenG
SirSevenG previously approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@SirSevenG SirSevenG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rechecked on Win 11 and Mac, app restarts correctly, coins are up including zhtlc.

@smk762 smk762 mentioned this pull request Dec 10, 2022
Open
Canialon
Canialon approved these changes Dec 10, 2022
View reviewed changes
Copy link
Contributor

@Canialon Canialon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good on Windows 10 and Mac
noticed that ARRR/ZOMBIE will start activation again if they were in activation process, nice:3

@smk762
Copy link
Collaborator Author

smk762 commented Dec 10, 2022

^^

Can you please recheck this one @tonymorony ?

@tonymorony tonymorony merged commit 6e7b678 into dev Dec 10, 2022
@smk762 smk762 mentioned this pull request Mar 6, 2023
Merged
@smk762 smk762 deleted the keep_active_on_restart branch August 7, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonymorony tonymorony tonymorony approved these changes

@cipig cipig cipig approved these changes

@Canialon Canialon Canialon approved these changes

@SirSevenG SirSevenG SirSevenG left review comments

@Milerius Milerius Awaiting requested review from Milerius

Assignees

@smk762 smk762

Labels
0.5.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST]: Reset assets config without losing enabled coins
6 participants
@smk762 @tonymorony @cipig @Milerius @SirSevenG @Canialon