Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak trade errors #2115

Merged
merged 6 commits into from Dec 2, 2022
Merged

Tweak trade errors #2115

merged 6 commits into from Dec 2, 2022

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Nov 25, 2022

closes: #2113
To test:

  • Warning messages/tooltips for pro and simple mode should be the same
  • zhtlc coins partially activated will display progress percentage
  • error messages should make sense
  • selecting a sell coin with zero balance shows placeholder and no spinning busy indicator visible
  • sell coin volume input is disabled unless coin has balance and busy indicator not spinning

@smk762 smk762 requested review from a user, tonymorony, SirSevenG and Canialon November 25, 2022 23:16
SirSevenG
SirSevenG previously approved these changes Nov 28, 2022
Copy link
Contributor

@SirSevenG SirSevenG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Canialon
Copy link
Contributor

There is no error about "..balance does not have enough funds to pay gas.."
like this(screenshot is from another branch):
Screenshot 2022-11-29 at 15 09 00
Instead of it, the user can "start" swap but will get an error(this branch):
image

@smk762
Copy link
Collaborator Author

smk762 commented Nov 29, 2022

Thanks for the catch - BTC should not have anything to do with gas! I'll revisit the logic and see where it went wrong.

@smk762 smk762 changed the title add simple mode placeholder for partially activated zhtlc Tweak trade errors Nov 29, 2022
@smk762
Copy link
Collaborator Author

smk762 commented Nov 29, 2022

@Canialon should be fixed now

Canialon
Canialon previously approved these changes Nov 29, 2022
@smk762 smk762 requested a review from cipig November 30, 2022 10:40
@SirSevenG
Copy link
Contributor

On selecting coin with 0 balance in simple form as trade From, there're no error for it and infinite spinner on top of the form.

[13:14:48] [warning] [qt.trading.page.cpp:908] [4079]: last_trading_error is BalanceIsLessThanTheMinimalTradingAmount
[13:14:48] [info] [qt.orderbook.model.cpp:388] [4079]: full orderbook initialization initial size: 0 target size: 1, orderbook_kind: 1
[13:14:48] [info] [qt.orderbook.model.cpp:388] [4079]: full orderbook initialization initial size: 0 target size: 6, orderbook_kind: 2
[13:14:48] [info] [qt.orderbook.cpp:113] [4079]: selected best orders have a value - set preffered order
[13:14:48] [warning] [qt.trading.page.cpp:1473] [4079]: Spurious min_diff detected - (not) overriding immediately (using get_orderbook_wrapper()->get_current_min_taker_vol())

@smk762 smk762 requested a review from Canialon December 1, 2022 15:46
@smk762
Copy link
Collaborator Author

smk762 commented Dec 1, 2022

On selecting coin with 0 balance in simple form as trade From, there're no error for it and infinite spinner on top of the form.

[13:14:48] [warning] [qt.trading.page.cpp:908] [4079]: last_trading_error is BalanceIsLessThanTheMinimalTradingAmount
[13:14:48] [info] [qt.orderbook.model.cpp:388] [4079]: full orderbook initialization initial size: 0 target size: 1, orderbook_kind: 1
[13:14:48] [info] [qt.orderbook.model.cpp:388] [4079]: full orderbook initialization initial size: 0 target size: 6, orderbook_kind: 2
[13:14:48] [info] [qt.orderbook.cpp:113] [4079]: selected best orders have a value - set preffered order
[13:14:48] [warning] [qt.trading.page.cpp:1473] [4079]: Spurious min_diff detected - (not) overriding immediately (using get_orderbook_wrapper()->get_current_min_taker_vol())

Thanks for the feedback - should be fixed now.

@smk762 smk762 self-assigned this Dec 2, 2022
@smk762 smk762 merged commit 530b4cf into dev Dec 2, 2022
@smk762 smk762 mentioned this pull request Mar 6, 2023
@smk762 smk762 deleted the trade_error_refactor branch August 7, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Trade errors code duplicated and inconsistent
3 participants