Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force zhtlc activation the good old fashioned way #2168

Merged
merged 1 commit into from Dec 9, 2022

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Dec 7, 2022

Mitigates #2142 (can leave issue open for later)

To test:

  • disable ARRR
  • Go to simple view, select KMD as "From" coin
  • Scroll thru "To" coin list and click on ARRR. You should see message saying to enable via coin activation menu.
  • Click on a disabled non-zhtlc coin. You should be able to enable it from the pop up.
  • disable ARRR
  • Go to pro view, select to sell KMD, and select an order from the orderbook to make bestorders populate
  • Scroll thru bestorders and click on ARRR. You should see message saying to enable via coin activation menu.
  • Click on a disabled non-zhtlc coin. You should be able to enable it from the pop up.

@SirSevenG this PR does not solve the potential crash issue you posted, but will stop a user from being unable to get to where the crash might occur. A more complete fix could be implemented later, but for now this defends against the worst outcome.

@smk762 smk762 requested review from a user, cipig, SirSevenG and Canialon December 7, 2022 15:05
Copy link
Contributor

@SirSevenG SirSevenG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the job

@smk762 smk762 merged commit ae9680b into dev Dec 9, 2022
@smk762 smk762 deleted the no_activation_pop_up_for_zhtlc branch December 9, 2022 19:33
@smk762 smk762 mentioned this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants