Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST]: enable automatic merge of utxos #1784

Open
cipig opened this issue Jun 2, 2022 · 8 comments
Open

[FEATURE REQUEST]: enable automatic merge of utxos #1784

cipig opened this issue Jun 2, 2022 · 8 comments

Comments

@cipig
Copy link
Member

cipig commented Jun 2, 2022

ADEX API supports automatic merging of utxos, like this: curl --url "http://127.0.0.1:7783" --data "{\"method\":\"electrum\",\"coin\":\"RICK\",\"servers\":[{\"url\":\"electrum1.cipig.net:20017\",\"protocol\":\"SSL\"},{\"url\":\"electrum2.cipig.net:20017\",\"protocol\":\"SSL\"},{\"url\":\"electrum3.cipig.net:20017\",\"protocol\":\"SSL\"}],\"userpass\":\"$userpass\",\"mm2\":1,\"utxo_merge_params\":{\"merge_at\":200,\"check_every\":600,\"max_merge_at_once\":100}}"

Can we please use this for all UTXO coins, except BTC (too high fees)?

Reason: If we don't do it and people have too many UTXOs, ADEX will stop working for that coin.

@smk762 smk762 added impact_ux next iteration to not forget to include it labels Jul 4, 2022
@smk762
Copy link
Collaborator

smk762 commented Jul 4, 2022

This should be optional, defaulting to off but configurable by user in settings.
Needs:

  • Back end code for method / inputs / outputs
  • Toggle in settings to activate (requires restart)
  • Mention in docs so we can point support queries from miners related to this.

@smk762
Copy link
Collaborator

smk762 commented Jul 4, 2022

related: #1436

@smk762
Copy link
Collaborator

smk762 commented Aug 1, 2022

I'm not sure there is a viable gui solution for this issue without either more than ideal complexity (e.g. coin specific settings) or being too broad (e.g. blanket application of the merge param).

It does need to be addressed though, as we regularly get people mining to their atomicdex wallet and accumulating thousands of utxos which they find difficult to consolidate.

A negotiated solution with no impact on front end and minimal technical expertise by the user could be to allow this to be defined within a user's coins.json file - so that on activation, if these flags / values are present, the coin will be activated accordingly.

The process would be simple enough to document in a guide for reference whenever needed.

@cipig would this solution be acceptable? If not, would it be an adequate starting point, with a future PR to add a "wizard" like for adding custom coins?

@cipig
Copy link
Member Author

cipig commented Aug 1, 2022

the easiest solution would be to apply the merge params to all utxo coins
if you keep the values rather high like \"merge_at\":200,\"check_every\":600,\"max_merge_at_once\":100}}", it will only affect the targeted users, since no normal user has 200 utxos in his address , i guess
txfee problems are only present with BTC utxos, all other coins have very low txfees, and nobody has 200 BTC utxos, at least not from mining :-)

but i am fine with any solution... we can start by adding the options to coins config in ADEX Desktop, so if they are present they are added to the enable/electrum call

@smk762
Copy link
Collaborator

smk762 commented Aug 1, 2022

The main problem with setting it by default is that it opens up potential perception of "unauthorised" transactions, and the user may experience confusion and think they have been hacked.

@cipig
Copy link
Member Author

cipig commented Aug 1, 2022

The main problem with setting it by default is that it opens up potential perception of "unauthorised" transactions, and the user may experience confusion and think they have been hacked.

Sure, but it would "affect" only few users with \"merge_at\":200 or higher.

@smk762 smk762 mentioned this issue Aug 15, 2022
@smk762
Copy link
Collaborator

smk762 commented Aug 16, 2022

I think we should maybe also add something that detects when there are > "x" utxos, and then show user a pop up warning which lets them toggle on utxo merging for the coin that needs it

@smk762 smk762 added 0.5.8 and removed next iteration to not forget to include it labels Nov 18, 2022
@smk762 smk762 added the P1 Major issue needs to be fixed label Jun 8, 2023
@smk762
Copy link
Collaborator

smk762 commented Jun 8, 2023

This issue is still not solved in a convenient way (requires support guidance and manual config), and comes up every few weeks from a user mining directly to the wallet.

@smk762 smk762 removed P1 Major issue needs to be fixed 0.5.8 labels Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants