Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Source missing icons from coins repo on build #2037

Closed
smk762 opened this issue Oct 31, 2022 · 0 comments · Fixed by #2194
Closed

[FR]: Source missing icons from coins repo on build #2037

smk762 opened this issue Oct 31, 2022 · 0 comments · Fixed by #2194
Assignees
Labels

Comments

@smk762
Copy link
Collaborator

smk762 commented Oct 31, 2022

Is your feature request related to a problem? Please describe.
Currently there is potential for a coin to exist in the coins repo but have no icon in the desktop repo. There is also a duplication of tasks making a PR to both repos each time a new coin is added.

Describe your solution
During build, we already source the coins file and the coins_config.json file. An extra step to confirm icons for all coins in coins_config.json are present, and if not, to add them should resolve this.

Describe alternatives you've considered
Alternatively, we could setup a CI workflow to do this check periodically, and if new icons are detected, make a bot create a PR to include them here.

@smk762 smk762 self-assigned this Oct 31, 2022
@smk762 smk762 added the 0.5.8 label Nov 21, 2022
@smk762 smk762 changed the title [FR]: Source missing icons from coins repo on build and assets reset [FR]: Source missing icons from coins repo on build Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant