Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST]: Address book #312

Closed
Milerius opened this issue Jul 3, 2020 · 2 comments
Closed

[FEATURE REQUEST]: Address book #312

Milerius opened this issue Jul 3, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request full-stack P1 Major issue needs to be fixed

Comments

@Milerius
Copy link
Contributor

Milerius commented Jul 3, 2020

Is your feature request related to a problem? Please describe.

The feature is not linked to a problem but to a lack.
We have no way of registering a public address for a name.

Describe the solution you'd like

I would like to be able to associate a public address with a name, this name could be associated with all a group like "ERC-20" or "SmartChains".

Later we could add categories: Friends, Professional, Contractual

Describe alternatives you've considered

Currently I use an external tool to which I associate an address to a name, but I therefore need to copy my public address from the application and then perform the search in my tool. It is laborious.

Additional context

  • Send / Withdraw feature are concerned.

A Json attempt of the addressbook format added to the wallet configuration:

{
    "wallet_name": "roman",
    "addressbook": {
        "ca333": {
            "ERC-20": "0xde0b295669a9fd93d5f28d9ec85e40f4cb697bae",
            "SmartChains": "RB49Rm4jBe5mN9anErvkzf3kcQCzHqyz3e",
            "BTC": "3FZbgi29cpjq2GjdwV8eyHuJJnkLtktZc5"
        },
        "alice": {
            "ERC-20": "0xde0b395669a9fd93d5f28d9ec85e40f4cb697bae",
            "SmartChains": "RB39Rm4jBe5mN9anErvkzf3kcQCzHqyz3e",
            "BTC": "3FZbgi30cpjq2GjdwV8eyHuJJnkLtktZc5"
        },
        "bob": {
            "ERC-20": "0xde0b393669a9fd93d5f28d9ec85e40f4cb697bae",
            "SmartChains": "RB39Rm6jBe5mN9anErvkzf3kcQCzHqyz3e",
            "BTC": "3FZbgi30cpjq3GjdwV8eyHuJJnkLtktZc5"
        }
    },
    "categories": {
        "friends": [
            "ca333"
        ],
        "pro": [
            "alice"
        ],
        "black_list": [
            "bob"
        ]
    }
}
@Milerius Milerius added the 0.2.0 label Jul 3, 2020
@tonymorony tonymorony added enhancement New feature or request P1 Major issue needs to be fixed labels Jul 9, 2020
@Milerius Milerius moved this from To do to In progress in AtomicDEX-Pro 0.2.0 (new UI) Jul 9, 2020
@tonymorony
Copy link
Contributor

tonymorony commented Jul 12, 2020

Address Book Desktop Concept

I think there might be dropdown scrollable list linked with addressbook when you input recepient (probably Audo can make it beautiful):

cf: #128

image

Also I've noticed that there is a lot of free space at the moment. I think it's fine to put addressbook button here for now (between receive and swap):

image

@tonymorony
Copy link
Contributor

impleneted in #357

@tonymorony tonymorony moved this from In progress to Done in AtomicDEX-Pro 0.2.0 (new UI) Jul 19, 2020
@ca333 ca333 mentioned this issue Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request full-stack P1 Major issue needs to be fixed
Projects
No open projects
Development

No branches or pull requests

3 participants