-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Addressbook entries are not validated #50
Comments
@naezith, Can you please have a look? |
There isn't any coin/address validation in this section (contact_edit.dart) so the field allows any kind of text. I looked for address validation in other places, and one of them is in the: _isCoinActive() function. So the Note: I'm not 100% sure so please correct me if it doesn't work like that. |
SDK validateaddress method: https://developers.komodoplatform.com/basic-docs/atomicdex-api-legacy/validateaddress.html Related issues from legacy desktop:
Related SDK issue: KomodoPlatform/komodo-defi-framework#1654 Currently a coin must be active to be validated, which is sub-optimal. Given data in coins file (e.g. base 58 params), addresses should be able to be calculated from the pubkey, either at the SDK level or the GUI level (though that is another issue). I assume until it is, the flow would be something like:
UX would be much better if validation did not require the coin to be active, so perhaps its better to solve that first. |
To replicate:
Seen in #44
The text was updated successfully, but these errors were encountered: