Line breaks not handled gracefully #131
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konafets
force-pushed
the
fix_issue_120
branch
3 times, most recently
from
341890b
to
799449e
Compare
This happened because the lexer got confused by the unknown Tag `imagekit` which comes from an addon. It was lexed and parsed as a variable and the syntax does not allow dynamic bindings for variables, only for Tags. This PR introduces an `T_UNKOWN_TAG` token, which is returned by the lexer when he sees an Identifier which is followed by one or more whitespaces and a colon. The formatting issues was just a side effect of the wrong parsing. Closes #120
Remove unused makros from `.flex` file and add a test which we ignore right now.
Add the `imagekit` Tag to the lexer.
- The construct which was used is a bit complicated and it turns out this was not needed. Additionally a method was used which was marked as "experimental" and got marked in the Verifier and on the Marketplace. Jetbrains recently pointed out that those APIs should be not used in the future, otherwise the plugin will get refused in the review. - Beside this, I migrated some more files to Kotlin and added an experimental new Formatter implementation. - With the changes in `AntlersFileViewProvider` we do not need `AntlersAstFactory` anymore and can retire it. For now its just disabled.
Use the settings to format the space.
- Add some style options for switch node - Fix spacing for parameter assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happened because the lexer got confused by the unknown Tag
imagekitwhich comes from an addon. It was lexed and parsed as a variable and the syntax does not allow dynamic bindings for variables, only for Tags. This PR introduces anT_UNKOWN_TAGtoken, which is returned by the lexer when he sees an Identifier which is followed by one or more whitespaces and a colon.The formatting issues was just a side effect of the wrong parsing.
Closes #120