Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admission): change admissionWebhook.failurePolicy value to Ignore #612

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

jrsmroz
Copy link
Contributor

@jrsmroz jrsmroz commented Jun 13, 2022

What this PR does / why we need it:

Which issue this PR fixes

kubernetes-ingress-controller/issues/2501

Special notes for your reviewer:

As suggested in kubernetes-ingress-controller/issues/2501 PR was tested manually:

Testing done:
  1. Verified that unique constraint of secrets does trigger failure when admission failure policy is Ignore as described in kubernetes-ingress-controller/issues/2431. Verified that Fail policy prevents config from being applied
  2. Verified that when controller is unreachable, the config is accepted if policy is Ignore.
  • Installed kic with admission failure policy enabled, failure policy Ignore and faked the controller connectivity problem by setting CONTROLLER_ADMISSION_WEBHOOK_LISTEN to off in helm charts.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@jrsmroz jrsmroz requested a review from a team as a code owner June 13, 2022 09:28
@CLAassistant
Copy link

CLAassistant commented Jun 13, 2022

CLA assistant check
All committers have signed the CLA.

charts/kong/CHANGELOG.md Outdated Show resolved Hide resolved
@pmalek
Copy link
Member

pmalek commented Jun 13, 2022

You might want to fix the checkmarks in PR description 🙃

Co-authored-by: Patryk Małek <malekpatryk+github@gmail.com>
@jrsmroz jrsmroz requested a review from a team June 13, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants